linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Korsnes <jkorsnes@cisco.com>
To: linux-usb@vger.kernel.org
Cc: Johan Korsnes <jkorsnes@cisco.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Armando Visconti <armando.visconti@st.com>,
	Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH v2 2/2] HID: core: increase HID report buffer size to 8KiB
Date: Fri, 17 Jan 2020 13:08:36 +0100	[thread overview]
Message-ID: <20200117120836.2354966-2-jkorsnes@cisco.com> (raw)
In-Reply-To: <20200117120836.2354966-1-jkorsnes@cisco.com>

We have a HID touch device that reports its opens and shorts test
results in HID buffers of size 8184 bytes. The maximum size of the HID
buffer is currently set to 4096 bytes, causing probe of this device to
fail. With this patch we increase the maximum size of the HID buffer to
8192 bytes, making device probe and acquisition of said buffers succeed.

Signed-off-by: Johan Korsnes <jkorsnes@cisco.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Armando Visconti <armando.visconti@st.com>
Cc: Jiri Kosina <jkosina@suse.cz>

---
v1 -> v2:
 * Clean-up of patch description (commit message)
---
 include/linux/hid.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/hid.h b/include/linux/hid.h
index cd41f209043f..875f71132b14 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -492,7 +492,7 @@ struct hid_report_enum {
 };
 
 #define HID_MIN_BUFFER_SIZE	64		/* make sure there is at least a packet size of space */
-#define HID_MAX_BUFFER_SIZE	4096		/* 4kb */
+#define HID_MAX_BUFFER_SIZE	8192		/* 8kb */
 #define HID_CONTROL_FIFO_SIZE	256		/* to init devices with >100 reports */
 #define HID_OUTPUT_FIFO_SIZE	64
 
-- 
2.24.1


  reply	other threads:[~2020-01-17 12:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-17 12:08 [PATCH v2 1/2] HID: core: fix off-by-one memset in hid_report_raw_event() Johan Korsnes
2020-01-17 12:08 ` Johan Korsnes [this message]
2020-02-12 13:19 ` Jiri Kosina
2020-02-12 13:26   ` Johan Korsnes (jkorsnes)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200117120836.2354966-2-jkorsnes@cisco.com \
    --to=jkorsnes@cisco.com \
    --cc=armando.visconti@st.com \
    --cc=jkosina@suse.cz \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).