From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC609C2D0DB for ; Mon, 20 Jan 2020 10:48:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFFA22087E for ; Mon, 20 Jan 2020 10:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579517287; bh=A6DiGLMBVimNXD2eBpF3hX6vLvICv8s7JH2mP4Y4tEE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ECCuY1FXWvENvcCvVtYsdaucmaUNspWZn3yNQn02QIlEYoyBMZLQqj/4ZTFFgqC40 MsBfG0K/lMRM2T5TEd6H2aL70ujNjPYql9E2BqQ4Ntchtrvig+PMxvCTbNH/ExbrV8 Gr/dIe93bzDliX7dhiXTHpvZrvhTs5aZhECEC9tI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726573AbgATKsH (ORCPT ); Mon, 20 Jan 2020 05:48:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:41096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbgATKsG (ORCPT ); Mon, 20 Jan 2020 05:48:06 -0500 Received: from localhost (unknown [89.205.129.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 56CE520674; Mon, 20 Jan 2020 10:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579517286; bh=A6DiGLMBVimNXD2eBpF3hX6vLvICv8s7JH2mP4Y4tEE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jTYgHek6QV1bzoQqCJmuScMbN05Mx+tdKBZaUm/Fnp5yvhChqecZgVdqv6W7vXgEF eTWkVzz1OhDsFbEpTed0g64ZfQDVhdqdD8bN4gHR7v61F2YoBgrCJVVnWU5qSkCxCL wb4XLsbsL62G7Vd2zH5qAU8QqADFE3QJs5qc7ugI= Date: Mon, 20 Jan 2020 11:48:01 +0100 From: Greg Kroah-Hartman To: Peter Chen Cc: "linux-usb@vger.kernel.org" , Felipe Balbi Subject: Re: No message is showed after USB gadget has configured Message-ID: <20200120104801.GA421434@kroah.com> References: <20200120090357.GB19938@b29397-desktop> <20200120092934.GA382520@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Jan 20, 2020 at 09:48:24AM +0000, Peter Chen wrote: > > > On Mon, Jan 20, 2020 at 09:03:59AM +0000, Peter Chen wrote: > > > Hi all, > > > > > > >From commit 1cbfb8c4f62d ("usb: gadget: Quieten gadget config > > > >message"), > > > there is no any message from gadget side after it connects to host and > > > works correctly. Although we could cat "state" under > > > /sys/class/udc/$CONTROLLER/ to know its state, we can't easily know if > > > the gadget works or not from console, USB host could have many > > > messages after one device has connected, why we can't keep one for USB > > > gadget? > > > > Why not make "normal" USB devices quieter too? :) > > > > Surely you do not have tools that watch syslog to determine if a device is working > > properly or not, right? That's what sysfs is for, not syslog entries. > > > > Yes, we use our eyes during the hot plug test for device or count the number of > messages for it, with this change, it may cause difficult for hot plug test. For > other tests, we could judge sysfs before later tests. > > Since this message in there many years, we (and tester) may need time to adapt for > this change. Can you just turn on dynamic debugging for that one line with a simple echo to the debugfs file so that you still see this in your test framework? thanks, greg k-h