From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Sergey Organov <sorganov@gmail.com>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: serial: fix Tx stall after buffer overflow
Date: Mon, 20 Jan 2020 15:05:40 +0100 [thread overview]
Message-ID: <20200120140540.GA31291@qmqm.qmqm.pl> (raw)
In-Reply-To: <87ftgagsdz.fsf@osv.gnss.ru>
On Mon, Jan 20, 2020 at 04:38:16PM +0300, Sergey Organov wrote:
> Michał Mirosław <mirq-linux@rere.qmqm.pl> writes:
>
> > On Mon, Jan 20, 2020 at 09:06:18AM +0300, Sergey Organov wrote:
> >> Michał Mirosław <mirq-linux@rere.qmqm.pl> writes:
> >> > The pr_debug() in other callers of gs_start_tx() say:
> >> > "caller: start ttyGS%d".
> >>
> >> ???
> >>
> >> $ git co gregkh/tty-next && grep -r 'caller: start tty' .
> >> HEAD is now at 7788f54... serial_core: Remove unused member in uart_port
> >> $
> >
> > Replace 'caller' with a function calling gs_start_io().
>
> Thanks, now I see... Do you prefer:
>
> pr_debug("gs_start_io: start Tx on ttyGS%d\n", port->port_num);
>
> then?
>
> Alternatively, I'm OK with removing this new debug print.
Let's remove it. I was convinced that this is a caller of gs_start_io()
and not the function itself. In this case callers already do the print.
BTW, the callers silently ignore (error) returns from this function. It
might be useful to add pr_err() catching the errors.
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2020-01-20 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 5:29 [PATCH] usb: gadget: serial: fix Tx stall after buffer overflow Sergey Organov
2020-01-17 20:34 ` Michał Mirosław
2020-01-20 6:06 ` Sergey Organov
2020-01-20 9:45 ` Michał Mirosław
2020-01-20 13:38 ` Sergey Organov
2020-01-20 14:05 ` Michał Mirosław [this message]
2020-01-21 6:41 ` Sergey Organov
2020-01-21 4:42 ` [PATCH v2] " Sergey Organov
2020-01-21 16:39 ` Michał Mirosław
2020-01-29 11:21 ` [PATCH v3] " Sergey Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120140540.GA31291@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sorganov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).