From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2] usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors
Date: Wed, 22 Jan 2020 10:15:56 +0100 [thread overview]
Message-ID: <20200122091556.GA2689180@kroah.com> (raw)
In-Reply-To: <20200106151005.321983-1-linus.walleij@linaro.org>
On Mon, Jan 06, 2020 at 04:10:05PM +0100, Linus Walleij wrote:
> Instead of using the legacy GPIO API and keeping track on
> polarity inversion semantics in the driver, switch to use
> GPIO descriptors for this driver and change all consumers
> in the process.
>
> This makes it possible to retire platform data completely:
> the only remaining platform data member was "wakeup" which
> was intended to make the vbus interrupt wakeup capable,
> but was not set by any users and thus remained unused. VBUS
> was not waking any devices up. Leave a comment about it so
> later developers using the platform can consider setting it
> to always enabled so plugging in USB wakes up the platform.
>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Cc: Daniel Mack <daniel@zonque.org>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Acked-by: Felipe Balbi <balbi@kernel.org>
> Acked-by: Sylwester Nawrocki <snawrocki@kernel.org>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> ChangeLog v1->v2:
> - Fix a chip label typo in mach-s3c64xx
> - Collect the ACKs!
With this applied, I now get the following build warnings:
drivers/usb/phy/phy-gpio-vbus-usb.c: In function ‘gpio_vbus_probe’:
drivers/usb/phy/phy-gpio-vbus-usb.c:237:11: warning: unused variable ‘gpio’ [-Wunused-variable]
237 | int err, gpio, irq;
| ^~~~
drivers/usb/phy/phy-gpio-vbus-usb.c:235:20: warning: unused variable ‘gpiod’ [-Wunused-variable]
235 | struct gpio_desc *gpiod;
| ^~~~~
Can you please fix that up and resend?
thanks,
greg k-h
prev parent reply other threads:[~2020-01-22 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 15:10 [PATCH v2] usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors Linus Walleij
2020-01-12 11:54 ` Robert Jarzmik
2020-01-14 0:29 ` Linus Walleij
2020-01-18 22:00 ` Robert Jarzmik
2020-01-22 9:15 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122091556.GA2689180@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robert.jarzmik@free.fr \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).