From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D41C2D0DB for ; Wed, 22 Jan 2020 14:50:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C9852465B for ; Wed, 22 Jan 2020 14:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579704620; bh=u9SBj+9hYN9VEo3dzqDkTH/o4P8ccCPD7ZsTLNri4aw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WmFDQENh/iZ1mt4/dUPkhnWb48eI8EnPJ6gMONrOptyL2/9MImmScQbDJwuuZNns2 L8etgICn6aV//tRof5CcU2zNrTowrv6uZAhUGYIBJoNm7FogceattdnckrtBOoMn4B KaQ1ZZn46mhovAzatVNSHCighQG/28nHVypwL4Bk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbgAVOuQ (ORCPT ); Wed, 22 Jan 2020 09:50:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:35364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbgAVOuP (ORCPT ); Wed, 22 Jan 2020 09:50:15 -0500 Received: from localhost (unknown [84.241.205.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6816921835; Wed, 22 Jan 2020 14:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579704615; bh=u9SBj+9hYN9VEo3dzqDkTH/o4P8ccCPD7ZsTLNri4aw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I7YzUKuNndmXKoO2rM4SrZLuKSnydO9PlMvUeQ3rj1CKNIANMTqpQwfcA6GWCaVQC 3M9X9ZG53L1luNJjJ+VZ47im0+k4GH1tbyi1TBnmR5OoGH9edilIf/ajhcMIStBF2T SSqQW2BQSR+EAhwPUsY67/UORTIOhqTYpRc+jKAY= Date: Wed, 22 Jan 2020 15:50:12 +0100 From: Greg Kroah-Hartman To: Andrey Konovalov Cc: Felipe Balbi , Jonathan Corbet , Alan Stern , Dmitry Vyukov , Alexander Potapenko , Marco Elver , USB list , LKML Subject: Re: [PATCH v5 1/1] usb: gadget: add raw-gadget interface Message-ID: <20200122145012.GB59473@kroah.com> References: <461a787e63a9a01d83edc563575b8585bc138e8d.1579007786.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Jan 22, 2020 at 03:37:46PM +0100, Andrey Konovalov wrote: > On Tue, Jan 14, 2020 at 2:24 PM Andrey Konovalov wrote: > > > > USB Raw Gadget is a kernel module that provides a userspace interface for > > the USB Gadget subsystem. Essentially it allows to emulate USB devices > > from userspace. Enabled with CONFIG_USB_RAW_GADGET. Raw Gadget is > > currently a strictly debugging feature and shouldn't be used in > > production. > > > > Raw Gadget is similar to GadgetFS, but provides a more low-level and > > direct access to the USB Gadget layer for the userspace. The key > > differences are: > > > > 1. Every USB request is passed to the userspace to get a response, while > > GadgetFS responds to some USB requests internally based on the provided > > descriptors. However note, that the UDC driver might respond to some > > requests on its own and never forward them to the Gadget layer. > > > > 2. GadgetFS performs some sanity checks on the provided USB descriptors, > > while Raw Gadget allows you to provide arbitrary data as responses to > > USB requests. > > > > 3. Raw Gadget provides a way to select a UDC device/driver to bind to, > > while GadgetFS currently binds to the first available UDC. > > > > 4. Raw Gadget uses predictable endpoint names (handles) across different > > UDCs (as long as UDCs have enough endpoints of each required transfer > > type). > > > > 5. Raw Gadget has ioctl-based interface instead of a filesystem-based one. > > > > Reviewed-by: Greg Kroah-Hartman > > Signed-off-by: Andrey Konovalov > > --- > > > > Greg, I've assumed your LGTM meant that I can add a Reviewed-by from you. > > > > Felipe, looking forward to your review, thanks! > > Hi Greg and Felipe, > > I was wondering if it's feasible to get this reviewed and merged > during the upcoming merge window? This patch is the only piece missing > to enable USB fuzzing for Android common kernels on syzbot. No objection from me, if Felipe acks it I can take it... thanks, greg k-h