From: Rob Herring <robh@kernel.org>
To: Mans Rullgard <mans@mansr.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH 1/2] dt-bindings: usb: add non-removable-ports hub property
Date: Mon, 27 Jan 2020 09:35:06 -0600 [thread overview]
Message-ID: <20200127153506.GA4589@bogus> (raw)
In-Reply-To: <20200124152504.23411-1-mans@mansr.com>
On Fri, Jan 24, 2020 at 03:25:03PM +0000, Mans Rullgard wrote:
> Add a non-removable-ports property that lists the hardwired downstream
> ports of a hub. Although hubs can provide this information, they are
> not always configured correctly. An alternate means of indicating this
> for built-in USB devices is thus useful.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
I reviewed this already, but since you didn't add my reviewed-by, I'm
looking at it again and having 2nd thoughts.
> ---
> Documentation/devicetree/bindings/usb/usb-device.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b/Documentation/devicetree/bindings/usb/usb-device.txt
> index 036be172b1ae..92d863cc96b6 100644
> --- a/Documentation/devicetree/bindings/usb/usb-device.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-device.txt
> @@ -66,6 +66,10 @@ Required properties for host-controller nodes with device nodes:
> - #size-cells: shall be 0
>
>
> +Optional properties for hub and host-controller nodes:
> +- non-removable-ports: list of hardwired downstream ports
If you have a hardwired device and need to know that, doesn't that imply
there's some other stuff you need to describe beyond what a standard USB
device has. Such as a power supply that's not Vbus from the hub.
At a minimum, I think this should be a per port property. Though really,
I think this should just be implied by describing the device in DT. I'm
not sure if there's a case for hotpluggable devices described in DT.
Maybe with overlays.
Rob
next prev parent reply other threads:[~2020-01-27 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 15:25 [RESEND][PATCH 1/2] dt-bindings: usb: add non-removable-ports hub property Mans Rullgard
2020-01-24 15:25 ` [RESEND][PATCH 2/2] usb: hub: use non-removable-ports DT property Mans Rullgard
2020-01-28 16:51 ` Greg Kroah-Hartman
2020-01-27 15:35 ` Rob Herring [this message]
2020-01-27 16:56 ` [RESEND][PATCH 1/2] dt-bindings: usb: add non-removable-ports hub property Måns Rullgård
2020-01-28 13:47 ` Greg Kroah-Hartman
2020-01-28 15:15 ` Måns Rullgård
2020-01-28 15:28 ` Greg Kroah-Hartman
2020-01-28 16:52 ` Greg Kroah-Hartman
2020-01-28 18:21 ` Rob Herring
2020-01-30 17:06 ` Måns Rullgård
2020-01-28 17:27 ` Rob Herring
2020-01-28 16:53 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127153506.GA4589@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mans@mansr.com \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).