From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3772C2D0DB for ; Thu, 30 Jan 2020 15:43:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B384320674 for ; Thu, 30 Jan 2020 15:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727261AbgA3Pni (ORCPT ); Thu, 30 Jan 2020 10:43:38 -0500 Received: from mx2.suse.de ([195.135.220.15]:36464 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726948AbgA3Pni (ORCPT ); Thu, 30 Jan 2020 10:43:38 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0319FAFCC; Thu, 30 Jan 2020 15:43:37 +0000 (UTC) Date: Thu, 30 Jan 2020 07:33:28 -0800 From: Davidlohr Bueso To: Johan Hovold Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: relax unthrottle memory barrier Message-ID: <20200130153328.jt5stb4svajrbkf6@linux-p48b> References: <20200130100658.683-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200130100658.683-1-johan@kernel.org> User-Agent: NeoMutt/20180716 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, 30 Jan 2020, Johan Hovold wrote: >Commit a8d78d9f3856 ("USB: serial: clean up throttle handling") >converted the throttle handling to use atomic bitops. This means that we >can relax the smp_mb() in unthrottle() to smp_mb__after_atomic(), which >for example is a no-op on architectures like x86 that provide fully >ordered atomics. > >Signed-off-by: Johan Hovold Reviewed-by: Davidlohr Bueso