linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	stable@vger.kernel.org, linux-input@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Martin Kepplinger <martink@posteo.de>
Subject: Re: [PATCH 1/7] Input: pegasus_notetaker: fix endpoint sanity check
Date: Tue, 4 Feb 2020 10:02:32 +0000	[thread overview]
Message-ID: <20200204100232.GB1088789@kroah.com> (raw)
In-Reply-To: <20200204082441.GD26725@localhost>

On Tue, Feb 04, 2020 at 09:24:41AM +0100, Johan Hovold wrote:
> On Tue, Dec 10, 2019 at 12:37:31PM +0100, Johan Hovold wrote:
> > The driver was checking the number of endpoints of the first alternate
> > setting instead of the current one, something which could be used by a
> > malicious device (or USB descriptor fuzzer) to trigger a NULL-pointer
> > dereference.
> > 
> > Fixes: 1afca2b66aac ("Input: add Pegasus Notetaker tablet driver")
> > Cc: stable <stable@vger.kernel.org>     # 4.8
> > Cc: Martin Kepplinger <martink@posteo.de>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> 
> Looks like the stable tag was removed when this one was applied, and
> similar for patches 2, 4 and 7 of this series (commits 3111491fca4f,
> a8eeb74df5a6, 6b32391ed675 upstream).
> 
> While the last three are mostly an issue for the syzbot fuzzer, we have
> started backporting those as well.
> 
> This one (bcfcb7f9b480) is more clear cut as it can be used to trigger a
> NULL-deref.
> 
> I only noticed because Sasha picked up one of the other patches in the
> series which was never intended for stable.

Did I end up catching all of these properly?  I've had to expand my
search for some patches like this that do not explicitly have the cc:
stable mark on them as not all subsystems do this well (if at all.)

And there's also Sasha's work in digging up patches based on patterns of
fixes, which also is needed because of this "problem".

thanks,

greg k-h

  reply	other threads:[~2020-02-04 10:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 11:37 [PATCH 0/7] Input: fix USB alsetting bugs Johan Hovold
2019-12-10 11:37 ` [PATCH 1/7] Input: pegasus_notetaker: fix endpoint sanity check Johan Hovold
2019-12-10 11:51   ` Martin Kepplinger
2020-02-04  8:24   ` Johan Hovold
2020-02-04 10:02     ` Greg KH [this message]
2020-02-04 10:14       ` Johan Hovold
2020-02-04 19:24         ` Dmitry Torokhov
2020-02-05 12:54           ` Johan Hovold
2019-12-10 11:37 ` [PATCH 2/7] Input: aiptek: " Johan Hovold
2019-12-11 11:55   ` Vladis Dronov
2019-12-10 11:37 ` [PATCH 3/7] Input: aiptek: use descriptors of current altsetting Johan Hovold
2019-12-10 11:37 ` [PATCH 4/7] Input: gtco: fix endpoint sanity check Johan Hovold
2019-12-11 11:59   ` Vladis Dronov
2019-12-10 11:37 ` [PATCH 5/7] Input: gtco: fix extra-descriptor debug message Johan Hovold
2019-12-10 11:37 ` [PATCH 6/7] Input: gtco: drop redundant variable reinit Johan Hovold
2019-12-10 11:37 ` [PATCH 7/7] Input: sur40: fix interface sanity checks Johan Hovold
2019-12-12 15:25 ` [PATCH 0/7] Input: fix USB alsetting bugs Vladis Dronov
2020-01-10 22:43   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200204100232.GB1088789@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martink@posteo.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).