From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Felipe Balbi <balbi@kernel.org>
Cc: Andrey Konovalov <andreyknvl@google.com>,
USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Alan Stern <stern@rowland.harvard.edu>,
Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>
Subject: Re: [PATCH v5 1/1] usb: gadget: add raw-gadget interface
Date: Wed, 5 Feb 2020 21:18:12 +0000 [thread overview]
Message-ID: <20200205211812.GD1399643@kroah.com> (raw)
In-Reply-To: <87tv4556ke.fsf@kernel.org>
On Wed, Feb 05, 2020 at 06:42:41PM +0200, Felipe Balbi wrote:
> > Overall, supporting O_NONBLOCK might be a useful feature for people
> > who are doing something else other than fuzzing, We can account for
> > potential future extensions that'll support it, so detecting
> > O_NONBLOCK and returning an error for now makes sense.
> >
> > WDYT?
>
> If that's the way you want to go, that's okay. But let's, then, prepare
> the code for extension later on. For example, let's add an IOCTL which
> returns the "version" of the ABI. Based on that, userspace can detect
> features and so on.
Ick, no, no version mess. If you have a new api, just add a new ioctl
and away you go, userspace can easily test for that. Don't go down the
path of trying to version your api, that way never works.
Trust me, been there, got the t-shirt, lived to regret it.
greg k-h
next prev parent reply other threads:[~2020-02-05 21:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 13:24 [PATCH v5 0/1] usb: gadget: add raw-gadget interface Andrey Konovalov
2020-01-14 13:24 ` [PATCH v5 1/1] " Andrey Konovalov
2020-01-14 14:00 ` Greg Kroah-Hartman
2020-01-22 14:37 ` Andrey Konovalov
2020-01-22 14:50 ` Greg Kroah-Hartman
2020-01-27 12:27 ` Andrey Konovalov
2020-01-31 13:42 ` Felipe Balbi
2020-01-31 14:43 ` Andrey Konovalov
2020-01-31 15:22 ` Felipe Balbi
2020-02-03 18:08 ` Andrey Konovalov
2020-02-05 16:42 ` Felipe Balbi
2020-02-05 17:25 ` Andrey Konovalov
2020-02-05 21:18 ` Greg Kroah-Hartman
2020-02-06 6:19 ` Felipe Balbi
2020-02-06 19:21 ` Andrey Konovalov
2020-02-05 21:18 ` Greg Kroah-Hartman [this message]
2020-02-06 6:14 ` Felipe Balbi
2020-01-31 21:42 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205211812.GD1399643@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreyknvl@google.com \
--cc=balbi@kernel.org \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).