From: Johan Hovold <johan@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: ti_usb_3410_5052: Replace zero-length array with flexible-array member
Date: Wed, 12 Feb 2020 08:59:29 +0100 [thread overview]
Message-ID: <20200212075929.GE4150@localhost> (raw)
In-Reply-To: <20200211232420.GA22388@embeddedor>
On Tue, Feb 11, 2020 at 05:24:20PM -0600, Gustavo A. R. Silva wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
> struct foo {
> int stuff;
> struct boo array[];
> };
>
> By making use of the mechanism above, we will get a compiler warning
> in case the flexible array does not occur last in the structure, which
> will help us prevent some kind of undefined behavior bugs from being
> inadvertenly introduced[3] to the codebase from now on.
>
> This issue was found with the help of Coccinelle.
Same here, the scripts may need to be updated as you missed a couple of
instances:
$ git grep '\[0\];' drivers/usb/serial
...
drivers/usb/serial/io_usbvend.h: __u8 Data[0]; // Data starts here
drivers/usb/serial/io_usbvend.h: __u8 Data[0]; // Download starts here
...
Could you replace these as well so that is done in one patch per
subsystem?
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/usb/serial/ti_usb_3410_5052.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
> index dd0ad67aa71e..db3ab25d9228 100644
> --- a/drivers/usb/serial/ti_usb_3410_5052.c
> +++ b/drivers/usb/serial/ti_usb_3410_5052.c
> @@ -219,7 +219,7 @@ struct ti_write_data_bytes {
> u8 bDataCounter;
> __be16 wBaseAddrHi;
> __be16 wBaseAddrLo;
> - u8 bData[0];
> + u8 bData[];
> } __packed;
>
> struct ti_read_data_request {
> @@ -234,7 +234,7 @@ struct ti_read_data_bytes {
> __u8 bCmdCode;
> __u8 bModuleId;
> __u8 bErrorCode;
> - __u8 bData[0];
> + __u8 bData[];
> } __packed;
>
> /* Interrupt struct */
Thanks,
Johan
next prev parent reply other threads:[~2020-02-12 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 23:24 [PATCH] USB: serial: ti_usb_3410_5052: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2020-02-12 7:59 ` Johan Hovold [this message]
2020-02-12 19:04 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212075929.GE4150@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).