From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: audio-v2: Add uac2_effect_unit_descriptor definition
Date: Mon, 17 Feb 2020 15:22:38 +0100 [thread overview]
Message-ID: <20200217142238.GA1144881@kroah.com> (raw)
In-Reply-To: <s5hd0adguv9.wl-tiwai@suse.de>
On Mon, Feb 17, 2020 at 03:18:34PM +0100, Takashi Iwai wrote:
> On Thu, 13 Feb 2020 12:20:58 +0100,
> Takashi Iwai wrote:
> >
> > The UAC2 Effect Unit Descriptor has a slightly different definition
> > from other similar ones like Processing Unit or Extension Unit.
> > Define it here so that it can be used in USB-audio driver in a later
> > patch.
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> > include/linux/usb/audio-v2.h | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/include/linux/usb/audio-v2.h b/include/linux/usb/audio-v2.h
> > index ba4b3e3327ff..cb9900b34b67 100644
> > --- a/include/linux/usb/audio-v2.h
> > +++ b/include/linux/usb/audio-v2.h
> > @@ -156,6 +156,18 @@ struct uac2_feature_unit_descriptor {
> > __u8 bmaControls[0]; /* variable length */
> > } __attribute__((packed));
> >
> > +/* 4.7.2.10 Effect Unit Descriptor */
> > +
> > +struct uac2_effect_unit_descriptor {
> > + __u8 bLength;
> > + __u8 bDescriptorType;
> > + __u8 bDescriptorSubtype;
> > + __u8 bUnitID;
> > + __le16 wEffectType;
> > + __u8 bSourceID;
> > + __u8 bmaControls[]; /* variable length */
> > +} __attribute__((packed));
> > +
> > /* 4.9.2 Class-Specific AS Interface Descriptor */
> >
> > struct uac2_as_header_descriptor {
>
> Greg, I suppose you are OK with this addition?
>
>
Yes, that's fine with me:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2020-02-17 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 11:20 [PATCH 0/2] ALSA: usb-audio: UAC2 effect unit parsing Takashi Iwai
2020-02-13 11:20 ` [PATCH 1/2] usb: audio-v2: Add uac2_effect_unit_descriptor definition Takashi Iwai
2020-02-17 14:18 ` Takashi Iwai
2020-02-17 14:22 ` Greg Kroah-Hartman [this message]
2020-02-17 14:25 ` Takashi Iwai
2020-02-13 11:20 ` [PATCH 2/2] ALSA: usb-audio: Parse source ID of UAC2 effect unit Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217142238.GA1144881@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).