Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sandeep Maheswaram <sanm@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Felipe Balbi <balbi@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Manu Gautam <mgautam@codeaurora.org>,
	Chandana Kishori Chiluveru <cchiluve@codeaurora.org>
Subject: Re: [PATCH v5 1/3] dt-bindings: usb: qcom,dwc3: Introduce interconnect properties for Qualcomm DWC3 driver
Date: Tue, 18 Feb 2020 15:02:58 -0600
Message-ID: <20200218210258.GA29667@bogus> (raw)
In-Reply-To: <1581668684-4182-2-git-send-email-sanm@codeaurora.org>

On Fri, Feb 14, 2020 at 01:54:42PM +0530, Sandeep Maheswaram wrote:
> Add documentation for the interconnects and interconnect-names
> properties for USB.
> 
> Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> index 4a36ab5..236877e 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> @@ -68,6 +68,22 @@ properties:
>    resets:
>      maxItems: 1
>  
> +  interconnects:
> +    description:
> +      Pairs of phandles and interconnect provider specifiers
> +      to denote the edge source and destination ports of
> +      the interconnect path. Please refer to
> +      Documentation/devicetree/bindings/interconnect/
> +      for more details.

No need to redefine a common property, but you do need to define how 
many entries (maxItems).

> +
> +  interconnect-names:
> +    description:
> +      List of interconnect path name strings sorted in the same
> +      order as the interconnects property. Consumer drivers will use
> +      interconnect-names to match interconnect paths with interconnect
> +      specifiers. Please refer to Documentation/devicetree/bindings/
> +      interconnect/ for more details.

Need to define what the names are.

Rob

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  8:24 [PATCH v5 0/3] ADD interconnect support " Sandeep Maheswaram
2020-02-14  8:24 ` [PATCH v5 1/3] dt-bindings: usb: qcom,dwc3: Introduce interconnect properties " Sandeep Maheswaram
2020-02-18 21:02   ` Rob Herring [this message]
2020-02-14  8:24 ` [PATCH v5 2/3] usb: dwc3: qcom: Add interconnect support in dwc3 driver Sandeep Maheswaram
2020-02-14 20:11   ` Matthias Kaehlcke
     [not found]     ` <d381164d-b749-4c93-de6d-72eca3e51341@codeaurora.org>
2020-03-24 17:07       ` Matthias Kaehlcke
2020-02-14  8:24 ` [PATCH v5 3/3] arm64: dts: sdm845: Add interconnect properties for USB Sandeep Maheswaram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200218210258.GA29667@bogus \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=balbi@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=cchiluve@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mgautam@codeaurora.org \
    --cc=mka@chromium.org \
    --cc=sanm@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git