From: Johan Hovold <johan@kernel.org>
To: Michael Hanselmann <public@hansmi.ch>
Cc: linux-usb@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Michael Dreher <michael@5dot1.de>,
Jonathan Olds <jontio@i4free.co.nz>
Subject: Re: [PATCH 4/4] ch341: Simulate break condition on HL340 variant
Date: Tue, 24 Mar 2020 11:55:27 +0100 [thread overview]
Message-ID: <20200324105527.GH5810@localhost> (raw)
In-Reply-To: <5da11e2b99cbf37bf741addbc4c28b9f3658efa2.1583520568.git.public@hansmi.ch>
On Fri, Mar 06, 2020 at 07:00:45PM +0000, Michael Hanselmann wrote:
> ch34x devices of the "HL340" variant don't support a real break
> condition. This fact is already used in the ch341_detect_hl340 function.
> With this change a quirk is implemented to simulate a break condition by
> temporarily lowering the baud rate and sending a NUL byte.
>
> The primary drawback of this approach is that the duration of the break
> can't be controlled by userland.
Hmm. I'll have to get back to you on this. Please continue keeping it
last in the series if you end up resubmitting before.
Johan
next prev parent reply other threads:[~2020-03-24 10:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 19:00 [PATCH 0/4] ch341: Add support for HL340 devices Michael Hanselmann
2020-03-06 19:00 ` [PATCH 1/4] ch341: Name more registers Michael Hanselmann
2020-03-24 10:20 ` Johan Hovold
2020-03-31 23:34 ` Michael Hanselmann
2020-03-06 19:00 ` [PATCH 2/4] ch341: Detect HL340 variant Michael Hanselmann
2020-03-24 10:31 ` Johan Hovold
2020-03-31 23:35 ` Michael Hanselmann
2020-03-06 19:00 ` [PATCH 3/4] ch341: Limit prescaler on " Michael Hanselmann
2020-03-24 10:41 ` Johan Hovold
2020-03-31 23:35 ` Michael Hanselmann
2020-03-06 19:00 ` [PATCH 4/4] ch341: Simulate break condition " Michael Hanselmann
2020-03-24 10:55 ` Johan Hovold [this message]
2020-03-24 10:05 ` [PATCH 0/4] ch341: Add support for HL340 devices Johan Hovold
2020-03-31 23:35 ` Michael Hanselmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324105527.GH5810@localhost \
--to=johan@kernel.org \
--cc=jontio@i4free.co.nz \
--cc=linux-usb@vger.kernel.org \
--cc=michael@5dot1.de \
--cc=public@hansmi.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).