From: Greg KH <gregkh@linuxfoundation.org>
To: Qiujun Huang <hqjagain@gmail.com>
Cc: johan@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, anenbupt@gmail.com
Subject: Re: [PATCH] USB: io_edgeport: fix slab-out-of-bounds Read in edge_interrupt_callback
Date: Thu, 26 Mar 2020 09:14:33 +0100 [thread overview]
Message-ID: <20200326081433.GA979574@kroah.com> (raw)
In-Reply-To: <1585122757-4528-1-git-send-email-hqjagain@gmail.com>
On Wed, Mar 25, 2020 at 03:52:37PM +0800, Qiujun Huang wrote:
> The boundary condition should be (length - 1) as we access data[position+1].
>
> Reported-and-tested-by: syzbot+37ba33391ad5f3935bbd@syzkaller.appspotmail.com
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> ---
> drivers/usb/serial/io_edgeport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c
> index 5737add..4cca0b8 100644
> --- a/drivers/usb/serial/io_edgeport.c
> +++ b/drivers/usb/serial/io_edgeport.c
> @@ -710,7 +710,7 @@ static void edge_interrupt_callback(struct urb *urb)
> /* grab the txcredits for the ports if available */
> position = 2;
> portNumber = 0;
> - while ((position < length) &&
> + while ((position < length - 1) &&
> (portNumber < edge_serial->serial->num_ports)) {
> txCredits = data[position] | (data[position+1] << 8);
> if (txCredits) {
> --
> 1.8.3.1
>
Johan, any objection from me taking this in my tree now?
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-26 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 7:52 [PATCH] USB: io_edgeport: fix slab-out-of-bounds Read in edge_interrupt_callback Qiujun Huang
2020-03-26 8:14 ` Greg KH [this message]
2020-03-26 8:21 ` Johan Hovold
2020-03-26 9:13 ` Johan Hovold
2020-03-26 9:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326081433.GA979574@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anenbupt@gmail.com \
--cc=hqjagain@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).