From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4CA6C43331 for ; Fri, 27 Mar 2020 08:46:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A58D820716 for ; Fri, 27 Mar 2020 08:46:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726266AbgC0IqV (ORCPT ); Fri, 27 Mar 2020 04:46:21 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:46509 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726169AbgC0IqU (ORCPT ); Fri, 27 Mar 2020 04:46:20 -0400 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jHkd6-0001qQ-Oo; Fri, 27 Mar 2020 09:46:16 +0100 Received: from mgr by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jHkd4-0000fZ-E7; Fri, 27 Mar 2020 09:46:14 +0100 From: Michael Grzeschik To: lars@metafoo.de, alexandru.Ardelean@analog.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@kernel.org Cc: gregkh@linuxfoundation.org, bigeasy@linutronix.de, m.olbrich@pengutronix.de, kernel@pengutronix.de Subject: [PATCH] usb: dwc3: gadget: don't dequeue requests on already disabled endpoints Date: Fri, 27 Mar 2020 09:43:03 +0100 Message-Id: <20200327084302.606-1-m.grzeschik@pengutronix.de> X-Mailer: git-send-email 2.26.0.rc2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mgr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-usb@vger.kernel.org Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org dwc3_gadget_ep_disable gets called before the last request gets dequeued. In __dwc3_gadget_ep_disable all started, pending and cancelled lists for this endpoint will call dwc3_gadget_giveback in dwc3_remove_requests. After that no list containing the afterwards dequed request, therefor it is not necessary to run the dequeue routine. Signed-off-by: Michael Grzeschik --- @Lars-Peter Clausen: This patch addresses the case that not queued requests get dequeued. The only case that this happens seems on disabling the gadget. drivers/usb/dwc3/gadget.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 9a6f741d1db0dc..5d4fa8d6c93e49 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1609,6 +1609,9 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep, trace_dwc3_ep_dequeue(req); + if (!(dep->flags & DWC3_EP_ENABLED)) + return 0; + spin_lock_irqsave(&dwc->lock, flags); list_for_each_entry(r, &dep->pending_list, list) { -- 2.26.0.rc2