From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7E10C43331 for ; Fri, 27 Mar 2020 15:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D89F20675 for ; Fri, 27 Mar 2020 15:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=horus.com header.i=@horus.com header.b="YNwjOlfX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727726AbgC0PEO (ORCPT ); Fri, 27 Mar 2020 11:04:14 -0400 Received: from mail.horus.com ([78.46.148.228]:49547 "EHLO mail.horus.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727322AbgC0PEO (ORCPT ); Fri, 27 Mar 2020 11:04:14 -0400 Received: from lenny.lan (193-83-225-155.adsl.highway.telekom.at [193.83.225.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "E-Mail Matthias Reichl Lenny", Issuer "HiassofT CA 2014" (verified OK)) by mail.horus.com (Postfix) with ESMTPSA id 6E612640AE; Fri, 27 Mar 2020 16:04:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=horus.com; s=20180324; t=1585321452; bh=jzrJa97gngOuEsLDSp7j99HNV6vcsFyI+qOIZ0pY84k=; h=From:To:Cc:Subject:Date:From; b=YNwjOlfXb2VN/VpIJhGuaQfm+qnFP0i2ES7p0eiEIfvD/xJQVm5j17r20gO3SznFA JJiSJyL0ESuw5Rbl9QnElw+NXzX+ckSfp705FsJP0vvMw9/Bm66CpVK35JcorJMsaK lxRKWdEWe53YS9qVfPFmtxTKCOFct7rT4RgSbV/Y= Received: by lenny.lan (Postfix, from userid 1000) id E42A1202E5E; Fri, 27 Mar 2020 16:04:11 +0100 (CET) From: Matthias Reichl To: Anthony Mallet , Greg Kroah-Hartman , Oliver Neukum Cc: linux-usb@vger.kernel.org, Matthias Reichl Subject: [PATCH] USB: cdc-acm: restore capability check order Date: Fri, 27 Mar 2020 16:03:50 +0100 Message-Id: <20200327150350.3657-1-hias@horus.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org commit b401f8c4f492c ("USB: cdc-acm: fix rounding error in TIOCSSERIAL") introduced a regression by changing the order of capability and close settings change checks. When running with CAP_SYS_ADMIN setting the close settings to the values already set resulted in -EOPNOTSUPP. Fix this by changing the check order back to how it was before. Fixes: b401f8c4f492c ("USB: cdc-acm: fix rounding error in TIOCSSERIAL") Signed-off-by: Matthias Reichl --- drivers/usb/class/cdc-acm.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 47f09a6ce7bda..84d6f7df09a4e 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -923,16 +923,16 @@ static int set_serial_info(struct tty_struct *tty, struct serial_struct *ss) mutex_lock(&acm->port.mutex); - if ((ss->close_delay != old_close_delay) || - (ss->closing_wait != old_closing_wait)) { - if (!capable(CAP_SYS_ADMIN)) + if (!capable(CAP_SYS_ADMIN)) { + if ((ss->close_delay != old_close_delay) || + (ss->closing_wait != old_closing_wait)) retval = -EPERM; - else { - acm->port.close_delay = close_delay; - acm->port.closing_wait = closing_wait; - } - } else - retval = -EOPNOTSUPP; + else + retval = -EOPNOTSUPP; + } else { + acm->port.close_delay = close_delay; + acm->port.closing_wait = closing_wait; + } mutex_unlock(&acm->port.mutex); return retval; -- 2.20.1