From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E4FBC2D0F0 for ; Wed, 1 Apr 2020 12:57:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7CCA20675 for ; Wed, 1 Apr 2020 12:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585745878; bh=/7CdyfHR1LqxImi2jBxcvtSv+PPjOxapBSIg4fyZ97w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=p9izFYBHiSEQQNzBeZ1iurq7Chd/r4XwY7h/o27ziHC9ObecqPJsYQiKD6LdGKovh 3W1fYJqtLdoMwpt57PKzViuZnekYZBVhS/3UUvF9WhHznSkyk8MF9qcghmandtO5+u YZ3LeLgYGRKuPVB8Y98dSTedxp/auhqTDmBOyPv8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732561AbgDAM5z (ORCPT ); Wed, 1 Apr 2020 08:57:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:50518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732507AbgDAM5y (ORCPT ); Wed, 1 Apr 2020 08:57:54 -0400 Received: from localhost (unknown [122.167.76.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 932C920658; Wed, 1 Apr 2020 12:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585745873; bh=/7CdyfHR1LqxImi2jBxcvtSv+PPjOxapBSIg4fyZ97w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tt1PrdNJE62LxSxlqYUgjLQIfVkELT30zWfC2MfSXjWjYTpZqAkrPeDF7RffkyPit H1Ptvid/MNDvzvBsXUAbCbXcWSvzTL4vR0+1gWz4EJ92c4RxdCCYIGB9zv0YoyUEEw f3V1AoywopTN2aXyHjbEaFWPMizhhX4AZAtltrls= Date: Wed, 1 Apr 2020 18:27:48 +0530 From: Vinod Koul To: Mathias Nyman Cc: Mathias Nyman , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Yoshihiro Shimoda , Christian Lamparter , John Stultz , Alan Stern , Andreas =?iso-8859-1?Q?B=F6hler?= , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 3/5] usb: xhci: Add support for Renesas controller with memory Message-ID: <20200401125748.GC72691@vkoul-mobl> References: <20200323170601.419809-1-vkoul@kernel.org> <20200323170601.419809-4-vkoul@kernel.org> <6ea778a7-6d58-6dae-bd65-3a63a945fb97@linux.intel.com> <20200326115117.GZ72691@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200326115117.GZ72691@vkoul-mobl> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 26-03-20, 17:21, Vinod Koul wrote: > On 26-03-20, 13:29, Mathias Nyman wrote: > > Hi Vinod > > > > On 23.3.2020 19.05, Vinod Koul wrote: > > > Some rensas controller like uPD720201 and uPD720202 need firmware to be > > > loaded. Add these devices in table and invoke renesas firmware loader > > > functions to check and load the firmware into device memory when > > > required. > > > > > > Signed-off-by: Vinod Koul > > > --- > > > drivers/usb/host/xhci-pci-renesas.c | 1 + > > > drivers/usb/host/xhci-pci.c | 29 ++++++++++++++++++++++++++++- > > > drivers/usb/host/xhci-pci.h | 3 +++ > > > 3 files changed, 32 insertions(+), 1 deletion(-) > > > > > > > It's unfortunate if firmware loading couldn't be initiated in a PCI fixup hook > > for this Renesas controller. What was the reason it failed? > > > > Nicolas Saenz Julienne just submitted a solution like that for Raspberry Pi 4 > > where firmware loading is initiated in pci-quirks.c quirk_usb_early_handoff() > > > > https://lore.kernel.org/lkml/20200324182812.20420-1-nsaenzjulienne@suse.de > > > > Is he doing something different than what was done for the Renesas controller? > > I tried and everytime ended up not getting firmware. Though I did not > investigate a lot. Christian seemed to have tested sometime back as > well. > > Another problem is that we dont get driver_data in the quirk and there > didnt seem a way to find the firmware name. > > > > diff --git a/drivers/usb/host/xhci-pci-renesas.c b/drivers/usb/host/xhci-pci-renesas.c > > > index c588277ac9b8..d413d53df94b 100644 > > > --- a/drivers/usb/host/xhci-pci-renesas.c > > > +++ b/drivers/usb/host/xhci-pci-renesas.c > > > @@ -336,6 +336,7 @@ static void renesas_fw_callback(const struct firmware *fw, > > > goto cleanup; > > > } > > > > > > + xhci_pci_probe(pdev, ctx->id); > > > return; > > > > I haven't looked into this but instead of calling xhci_pci_probe() here in the async fw > > loading callback could we just return -EPROBE_DEFER until firmware is loaded when > > xhci_pci_probe() is originally called? > > Hmm, initially my thinking was how to tell device core to probe again, > and then digging up I saw wait_for_device_probe() which can be used, let > me try that Sorry to report back that it doesn't work as planned :( I modified the code to invoke the request_firmware_nowait() which will load the firmware and provide the firmware in callback. Meanwhile return -EPROBE_DEFER. After a bit, the core invokes the driver probe again and we hit the roadblock. The request_firmware uses devres and allocates resources for loading the firmware. The problem is that device core checks for this: bus: 'pci': really_probe: probing driver xhci_hcd_pci with device 0000:01:00.0 pci 0000:01:00.0: Resources present before probing And here the probe fails. In some cases the firmware_callback finishes before this and we can probe again, but that is not very reliable. I tested another way to use request_firmware() (sync version) and then load the firmware in probe and load. The request is done only for renesas devices if they dont have firmware already running. So rest of the devices wont have any impact. Now should we continue this way in the patchset or move to sync version. Am okay either way. -- ~Vinod