From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF7FC83007 for ; Wed, 29 Apr 2020 07:40:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 409322073E for ; Wed, 29 Apr 2020 07:40:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588146039; bh=vT0nc6JP1XAbhEu/xWlWApVMT/AgweeuCYtCLOPZvik=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=evd+u8hKhN0zsloHcKN3ccCn5vK74bxKTH7ddHNPbpp+APJHouoIL7c7mY0/Euacp 6SLPBo6xTVhy56E8/kWRjqf4sd3FxfmHF3jWZDmhjSrQg+2Y8RSjkeDCUyZ5fVyjBO sGz8vJ1I1l/i/uWlrk/JZsy157JMKafsIktZBIMc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726423AbgD2Hkg (ORCPT ); Wed, 29 Apr 2020 03:40:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:43846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726355AbgD2Hkf (ORCPT ); Wed, 29 Apr 2020 03:40:35 -0400 Received: from Mani-XPS-13-9360 (unknown [157.46.25.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F1AA42073E; Wed, 29 Apr 2020 07:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588146034; bh=vT0nc6JP1XAbhEu/xWlWApVMT/AgweeuCYtCLOPZvik=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aOWD4Hlawou5o0CTYK8q0icBT7hswPxiDZC3nVwT0Jo9Xd8Z2M8CP1kLZhS2/9AVs bYPgaHHY6+OCUhAEhO5SpvHoLtuS0cpNVRwQMuDPQAAGlomZT+ZrVwmx2zeW/+MCz5 qHQZTI8CawBO30E2PgMwf+HahaIU0UyIRIAD20e4= Date: Wed, 29 Apr 2020 13:10:26 +0530 From: Manivannan Sadhasivam To: Greg KH Cc: johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, patong.mxl@gmail.com Subject: Re: [PATCH 1/2] usb: serial: Add MaxLinear/Exar USB to Serial driver Message-ID: <20200429074025.GA6443@Mani-XPS-13-9360> References: <20200428195651.6793-1-mani@kernel.org> <20200428195651.6793-2-mani@kernel.org> <20200429072036.GA2045202@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429072036.GA2045202@kroah.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Greg, On Wed, Apr 29, 2020 at 09:20:36AM +0200, Greg KH wrote: > On Wed, Apr 29, 2020 at 01:26:50AM +0530, mani@kernel.org wrote: > > From: Manivannan Sadhasivam > > > > Add support for MaxLinear/Exar USB to Serial converters. This driver > > only supports XR21V141X series but provision has been made to support > > other series in future. > > > > This driver is inspired from the initial one submitted by Patong Yang: > > > > https://patchwork.kernel.org/patch/10543261/ > > > > While the initial driver was a custom tty USB driver exposing whole > > new serial interface ttyXRUSBn, this version is completely based on USB > > serial core thus exposing the interfaces as ttyUSBn. This will avoid > > the overhead of exposing a new USB serial interface which the userspace > > tools are unaware of. > > Nice work! > > Some comments below: > > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * MaxLinear/Exar USB to Serial driver > > + * > > + * Based on initial driver written by Patong Yang > > + * > > + * Copyright (c) 2020 Manivannan Sadhasivam > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "xr_serial.h" > > No need for a .h file for a single .c file. > Yeah but since this driver can support multiple series of XR chips (they might have separate register definitions and such), I thought it is a good idea to have a header file to keep the driver sane. But can club it to the source file for now. > > +static int xr_get_reg(struct usb_serial_port *port, u8 block, u16 reg, > > + u16 *val) > > +{ > > + struct usb_serial *serial = port->serial; > > + struct xr_port_private *port_priv = usb_get_serial_port_data(port); > > + void *dmabuf; > > + int ret = -EINVAL; > > + > > + dmabuf = kmalloc(sizeof(reg), GFP_KERNEL); > > So that is 2 bytes? > Explanation below... > > + if (!dmabuf) > > + return -ENOMEM; > > + > > + if (port_priv->idProduct == XR21V141X_ID) { > > + /* XR21V141X uses custom command for reading UART registers */ > > + ret = usb_control_msg(serial->dev, > > + usb_rcvctrlpipe(serial->dev, 0), > > + XR_GET_XR21V141X, > > + USB_DIR_IN | USB_TYPE_VENDOR, 0, > > + reg | (block << 8), dmabuf, > > + port_priv->reg_width, > > + USB_CTRL_SET_TIMEOUT); > > + } > > + > > + if (ret == port_priv->reg_width) { > > + memcpy(val, dmabuf, port_priv->reg_width); > > But here you copy ->reg_width bytes in? How do you know val can hold > that much? It's only set to be 1, so you copy 1 byte to a 16bit value? > What part of the 16bits did you just copy those 8 bits to (hint, think > cpu endian issues...) > > That feels really really odd and a bit broken. > Right. The reason is, the other series which can be supported by this driver have different register widths. For instance XR2280x. I haven't used them personally but seen this in initial driver. So I just used the max u16 type to make the reg_{set/get} routines work with those. But agree, I should've used le16_to_cpu() cast to avoid endian issues. If you think this hack is not required now, I can just use u8 and worry about compatibility later. > > --- /dev/null > > +++ b/drivers/usb/serial/xr_serial.h > > @@ -0,0 +1,103 @@ > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > Are you sure about the "+"? I have to ask :) > I'm not a fan but since I've inherited the code from initial driver (which was GPL-2.0+), I kept it. > > + > > +#ifndef __LINUX_USB_SERIAL_XR_SERIAL_H > > +#define __LINUX_USB_SERIAL_XR_SERIAL_H > > As you will drop this file, just a general statement, no need for > __LINUX as this is all Linux :) > Sure. Thanks, Mani > thanks, > > greg k-h