Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Bin Liu <b-liu@ti.com>
To: Alan Stern <stern@rowland.harvard.edu>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: musb: return -ESHUTDOWN in urb when three-strikes error happened
Date: Thu, 14 May 2020 10:37:31 -0500
Message-ID: <20200514153731.GC11463@iaqt7> (raw)
In-Reply-To: <20200514150259.GB11463@iaqt7>

On Thu, May 14, 2020 at 10:02:59AM -0500, Bin Liu wrote:
> On Thu, May 14, 2020 at 10:40:53AM -0400, Alan Stern wrote:
> > On Thu, May 14, 2020 at 09:28:03AM -0500, Bin Liu wrote:
> > > On Wed, May 13, 2020 at 09:32:05PM -0400, Alan Stern wrote:
> > > > On Wed, May 13, 2020 at 04:36:20PM -0500, Bin Liu wrote:
> > > > > When a USB device attached to a hub got disconnected, MUSB controller
> > > > > generates RXCSR_RX_ERROR interrupt for the 3-strikes-out error.
> > > > > 
> > > > > Currently the MUSB host driver returns -EPROTO in current URB, then the
> > > > > USB device driver could immediately resubmit the URB which causes MUSB
> > > > > generate RXCSR_RX_ERROR interrupt again. This circle causes interrupt
> > > > > storm then the hub never got a chance to report the USB device detach.
> > > > > 
> > > > > To fix the interrupt storm, change the URB return code to -ESHUTDOWN for
> > > > > MUSB_RXCSR_H_ERROR interrupt, so that the USB device driver will not
> > > > > immediately resubmit the URB.
> > > > > 
> > > > > Signed-off-by: Bin Liu <b-liu@ti.com>
> > > > 
> > > > Strictly speaking, this is not the right thing to do.  It goes against 
> > > > the API described in error-codes.rst.  A better approach would be to fix 
> > > 
> > > error-codes.rst says:
> > > 
> > > -ESHUTDOWN              The device or host controller has been
> > > 			disabled due to some problem that could not
> > > 			be worked around, such as a physical
> > > 			disconnect.
> > > 
> > > So -ESHUTDOWN is applicable in this case - the device is disconnected
> > > behind a hub.
> > 
> > Yes, but you don't _know_ that the device was disconnected.  All you 
> > know is that there was a 3-strikes error.  Other problems can cause such 
> > errors (noise, for example).
> 
> Yes, I know this. But we don't have a solution then. I cannot add
> resubmit delay in those ~500 device drivers.

By the way I don't think noise could last long enough to cause 3-strikes
error. A shortest USB packet is about 3-bytes long, a noise should be
just a glitch, it won't last at least 3-bytes long to supress the bus
and 3 times on the exact timing when the host expecting a response
packet. I cannot think of any other reason which can cause the 3-strikes
error other than the device is off the bus.

-Bin.

  reply index

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 21:36 Bin Liu
2020-05-14  1:32 ` Alan Stern
2020-05-14 14:28   ` Bin Liu
2020-05-14 14:40     ` Alan Stern
2020-05-14 15:02       ` Bin Liu
2020-05-14 15:37         ` Bin Liu [this message]
2020-05-14 16:26           ` Alan Stern
2020-05-14 17:00             ` Bin Liu
2020-05-14 18:55               ` Alan Stern
2020-05-19 17:12                 ` Bin Liu
2020-05-19 20:01                   ` Alan Stern
2020-05-20 14:31                     ` Bin Liu
2020-05-20 16:40                       ` Alan Stern
2020-05-20 18:05                         ` Bin Liu
2020-05-20 18:25                           ` Alan Stern
2020-05-20 18:59                             ` Bin Liu
2020-05-19 17:28             ` [PATCH v2] " Bin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514153731.GC11463@iaqt7 \
    --to=b-liu@ti.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git