From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7DE3C433E0 for ; Mon, 18 May 2020 22:44:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4F4D20756 for ; Mon, 18 May 2020 22:44:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mACWKIf6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726806AbgERWn7 (ORCPT ); Mon, 18 May 2020 18:43:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726359AbgERWn6 (ORCPT ); Mon, 18 May 2020 18:43:58 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70C98C061A0C for ; Mon, 18 May 2020 15:43:58 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id u5so5501761pgn.5 for ; Mon, 18 May 2020 15:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Yqx7fwzdjHJkmgg9PpHSWruK1legOs9tOHB9RxnwbRs=; b=mACWKIf6r3CqCdMcDBn6VjpepgfOd38WJ3opB+zwOCwxfXXdrBEKsrATprGGroAeMp wot++3+d03nJK0ZPSe+gJZuyUoYC3hQ4Z5zmK5de4eRmDwRQmvmHX2BJc/BGWKLPpvpF txm+8RCl4VFZUOqT3ZZr4VTpnCbW04VJfhQ3Lm3z/iRHkFx7eFp6mvCH9JcO46pQHYE/ 8rdPZMVduzbwNmQWSV95602GHTGAunWlY9GxhKRCZ9fap3cJgkyAcVwwVPAmU+Ock3uh vBcYLsSElqLyph0oIep9XjvpkQrsS7xjUIVE+jhf+sa8MScL7Z7/aSb6cVbcnRIcNI1+ 61+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Yqx7fwzdjHJkmgg9PpHSWruK1legOs9tOHB9RxnwbRs=; b=qzP0DeYbTerciT/R4IoumYSMVHE5v+cWBBI+AbsZjdyhOYPRG5uPTzH0qrpECO+VdV U/saDjzhkMDevpjhSdUexAF5smQdUo3npf8bHMNgDO76F+bosbByNI6eB0dFuOaMfzfP G4EuyQfzikJQHx3lMAFwhkWJDZtTo1yRUtoQ1njbWgafVvK1rVZG8dihWcr62LEYibVC 5GFSftkG3qiVOToZIKBmCoZ/72sUAlaSZPJCEzVhLKDVjlWTMu677+IS/YEITc/zkm+v ed6dKUiNBSIB5MmKC3lRxqiPcZYInSiE0BFJQxsWOIjm1jsmzkLxAYNEAMB67CsOQZB4 2g7w== X-Gm-Message-State: AOAM533BAW8pf1zGJCi5nR6Iap5gB7P1Fl/qQe2HWJTFq1It8TPe8p3V HtZ8qxDMHyG4DPxwLDE7B3WiPg== X-Google-Smtp-Source: ABdhPJxlIRTWrF03bepkBfTcA4XUBx8J3Q2qKZ56ZmeXbiQlsRaZjUwWtlIQFIFKflvwnVbnqLvxnA== X-Received: by 2002:aa7:973b:: with SMTP id k27mr2880419pfg.219.1589841837792; Mon, 18 May 2020 15:43:57 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id c21sm5583248pfo.131.2020.05.18.15.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 15:43:57 -0700 (PDT) Date: Mon, 18 May 2020 15:42:34 -0700 From: Bjorn Andersson To: Vinod Koul Cc: Anders Roxell , Arnd Bergmann , Mathias Nyman , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, Yoshihiro Shimoda , Christian Lamparter , John Stultz , Alan Stern , Andreas B?hler , linux-usb@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH v13 3/5] usb: xhci: Add support for Renesas controller with memory Message-ID: <20200518224234.GK2165@builder.lan> References: <20200506060025.1535960-1-vkoul@kernel.org> <20200506060025.1535960-4-vkoul@kernel.org> <20200518195719.GG374218@vkoul-mobl.Dlink> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200518195719.GG374218@vkoul-mobl.Dlink> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon 18 May 12:57 PDT 2020, Vinod Koul wrote: > Hi Anders, > > On 18-05-20, 19:53, Anders Roxell wrote: > > On Wed, 6 May 2020 at 08:01, Vinod Koul wrote: > > > > > > Some rensas controller like uPD720201 and uPD720202 need firmware to be > > > loaded. Add these devices in pci table and invoke renesas firmware loader > > > functions to check and load the firmware into device memory when > > > required. > > > > > > Signed-off-by: Vinod Koul > > > > Hi, I got a build error when I built an arm64 allmodconfig kernel. > > Thanks for this. This is happening as we have default y for USB_XHCI_PCI > and then we make USB_XHCI_PCI_RENESAS=m. That should be not allowed as > we export as symbol so both can be inbuilt or modules but USB_XHCI_PCI=y > and USB_XHCI_PCI_RENESAS=m cant. While it is valid that USB_XHCI_PCI=y|m > and USB_XHCI_PCI_RENESAS=n > > So this seems to get fixed by below for me. I have tested with > - both y and m (easy) > - make USB_XHCI_PCI_RENESAS=n, USB_XHCI_PCI=y|m works > - try making USB_XHCI_PCI=y and USB_XHCI_PCI_RENESAS=m, then > USB_XHCI_PCI=m by kbuild :) > - try making USB_XHCI_PCI=m and USB_XHCI_PCI_RENESAS=y, kbuild gives > error prompt that it will be m due to depends > > Thanks to all the fixes done by Arnd which pointed me to this. Pls > verify and I will send the fix with you as reported :) > > ---- >8 ---- > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > index b5c542d6a1c5..92783d175b3f 100644 > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -40,11 +40,11 @@ config USB_XHCI_DBGCAP > config USB_XHCI_PCI > tristate > depends on USB_PCI > + depends on USB_XHCI_PCI_RENESAS || !USB_XHCI_PCI_RENESAS This correctly captures the variations you describe above. Regards, Bjorn > default y > > config USB_XHCI_PCI_RENESAS > tristate "Support for additional Renesas xHCI controller with firwmare" > - depends on USB_XHCI_PCI > ---help--- > Say 'Y' to enable the support for the Renesas xHCI controller with > firwmare. Make sure you have the firwmare for the device and > > -- > ~Vinod