From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH] usb: typec: Ensure USB_ROLE_SWITCH is a dependency for tps6598x
Date: Wed, 20 May 2020 13:35:42 +0300 [thread overview]
Message-ID: <20200520103542.GF1298122@kuha.fi.intel.com> (raw)
In-Reply-To: <20200520100526.2729-1-bryan.odonoghue@linaro.org>
On Wed, May 20, 2020 at 11:05:26AM +0100, Bryan O'Donoghue wrote:
> When I switched on USB role switching for the tps6598x I completely forgot
> to add the Kconfig dependency.
>
> This patch ensures the dependency is there to prevent compilation error
> when role-switching is off.
There are stubs for the those functions, so there should not be any
compilation errors.
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> drivers/usb/typec/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
> index b4f2aac7ae8a..4ea18301b15e 100644
> --- a/drivers/usb/typec/Kconfig
> +++ b/drivers/usb/typec/Kconfig
> @@ -64,6 +64,7 @@ config TYPEC_HD3SS3220
> config TYPEC_TPS6598X
> tristate "TI TPS6598x USB Power Delivery controller driver"
> depends on I2C
> + depends on USB_ROLE_SWITCH
How about this:
depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH
We then would have an option to use this driver even without that when
its not needed.
thanks,
--
heikki
next prev parent reply other threads:[~2020-05-20 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 10:05 [PATCH] usb: typec: Ensure USB_ROLE_SWITCH is a dependency for tps6598x Bryan O'Donoghue
2020-05-20 10:35 ` Heikki Krogerus [this message]
2020-05-20 11:08 ` Bryan O'Donoghue
2020-05-20 11:13 ` Bryan O'Donoghue
2020-05-20 11:22 ` Bryan O'Donoghue
2020-05-20 11:52 ` Bryan O'Donoghue
2020-05-20 13:10 ` Heikki Krogerus
2020-05-20 18:20 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520103542.GF1298122@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=bryan.odonoghue@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).