From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
heikki.krogerus@linux.intel.com
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: [PATCH v2 2/2] usb: typec: Ensure USB_ROLE_SWITCH is selected for hd3ss3220
Date: Wed, 20 May 2020 13:33:12 +0100 [thread overview]
Message-ID: <20200520123312.320281-3-bryan.odonoghue@linaro.org> (raw)
In-Reply-To: <20200520123312.320281-1-bryan.odonoghue@linaro.org>
kbuild found a compile error with recent additions to the tps6598x to add
role-switch notification support. Digging into that error it turns out we
needed to add "select USB_ROLE_SWITCH" to Kconfig.
Adding "depends on USB_ROLE_SWITCH" as had previously been done for this
driver could still result in a link-time failure.
This patch propagates the tps6598x fix to hd3ss3220.
Fixes: da4b5d18dd94 ("usb: typec: add dependency for TYPEC_HD3SS3220")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
drivers/usb/typec/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
index a6cdf4ec0be6..8f84304802f4 100644
--- a/drivers/usb/typec/Kconfig
+++ b/drivers/usb/typec/Kconfig
@@ -53,7 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig"
config TYPEC_HD3SS3220
tristate "TI HD3SS3220 Type-C DRP Port controller driver"
depends on I2C
- depends on USB_ROLE_SWITCH
+ select USB_ROLE_SWITCH
help
Say Y or M here if your system has TI HD3SS3220 Type-C DRP Port
controller driver.
--
2.25.1
next prev parent reply other threads:[~2020-05-20 12:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 12:33 [PATCH v2 0/2] Fix role-switch selection in type-c drivers Bryan O'Donoghue
2020-05-20 12:33 ` [PATCH v2 1/2] usb: typec: Ensure USB_ROLE_SWITCH is selected for tps6598x Bryan O'Donoghue
2020-05-20 13:17 ` Heikki Krogerus
2020-05-20 13:24 ` Bryan O'Donoghue
2020-05-20 13:32 ` Bryan O'Donoghue
2020-05-20 13:39 ` Heikki Krogerus
2020-05-20 15:31 ` Bryan O'Donoghue
2020-05-20 12:33 ` Bryan O'Donoghue [this message]
2020-05-20 13:13 ` [PATCH v2 2/2] usb: typec: Ensure USB_ROLE_SWITCH is selected for hd3ss3220 Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520123312.320281-3-bryan.odonoghue@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).