From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH] usb: typec: Ensure USB_ROLE_SWITCH is a dependency for tps6598x
Date: Wed, 20 May 2020 16:10:52 +0300 [thread overview]
Message-ID: <20200520131052.GH1298122@kuha.fi.intel.com> (raw)
In-Reply-To: <8000f5b7-7652-4a31-6ec2-ac680c830823@linaro.org>
On Wed, May 20, 2020 at 12:52:36PM +0100, Bryan O'Donoghue wrote:
> So it should be "select USB_ROLE_SWITCH" not "depends on USB_ROLE_SWITCH"
No. The consumers of the switches should depend on it, not silently
select it.
> grep -r "USB_ROLE_SWITCH" * | grep depend
> drivers/usb/typec/Kconfig: depends on USB_ROLE_SWITCH
>
> grep -r "USB_ROLE_SWITCH" * | grep select
> drivers/extcon/Kconfig: select USB_ROLE_SWITCH
> drivers/usb/dwc3/Kconfig: select USB_ROLE_SWITCH
> drivers/usb/cdns3/Kconfig: select USB_ROLE_SWITCH
> drivers/usb/gadget/udc/Kconfig: select USB_ROLE_SWITCH
> drivers/usb/mtu3/Kconfig: select USB_ROLE_SWITCH
> drivers/usb/musb/Kconfig: select USB_ROLE_SWITCH
> drivers/usb/musb/Kconfig: select USB_ROLE_SWITCH
> drivers/usb/typec/tcpm/Kconfig: select USB_ROLE_SWITCH
> drivers/usb/typec/Kconfig: select USB_ROLE_SWITCH
> drivers/usb/typec/mux/Kconfig: select USB_ROLE_SWITCH
> drivers/usb/common/Kconfig: select USB_ROLE_SWITCH
Note that all those except tcpm supply the switch.
thanks,
--
heikki
next prev parent reply other threads:[~2020-05-20 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 10:05 [PATCH] usb: typec: Ensure USB_ROLE_SWITCH is a dependency for tps6598x Bryan O'Donoghue
2020-05-20 10:35 ` Heikki Krogerus
2020-05-20 11:08 ` Bryan O'Donoghue
2020-05-20 11:13 ` Bryan O'Donoghue
2020-05-20 11:22 ` Bryan O'Donoghue
2020-05-20 11:52 ` Bryan O'Donoghue
2020-05-20 13:10 ` Heikki Krogerus [this message]
2020-05-20 18:20 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520131052.GH1298122@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=bryan.odonoghue@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).