* [PATCH v3] usb: typec: Ensure USB_ROLE_SWITCH is set as a dependency for tps6598x
@ 2020-05-20 15:36 Bryan O'Donoghue
2020-05-20 15:43 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Bryan O'Donoghue @ 2020-05-20 15:36 UTC (permalink / raw)
To: linux-usb, gregkh, heikki.krogerus; +Cc: shawn.guo, Bryan O'Donoghue
When I switched on USB role switching for the tps6598x I completely forgot
to add the Kconfig dependency.
Ensure USB_ROLE_SWITCH is selected to prevent the typs6598x driver being
compiled in but the role-switch driver being compiled as a module, leading
to link error.
Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
drivers/usb/typec/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
index b4f2aac7ae8a..559dd06117e7 100644
--- a/drivers/usb/typec/Kconfig
+++ b/drivers/usb/typec/Kconfig
@@ -64,7 +64,8 @@ config TYPEC_HD3SS3220
config TYPEC_TPS6598X
tristate "TI TPS6598x USB Power Delivery controller driver"
depends on I2C
- select REGMAP_I2C
+ depends on REGMAP_I2C
+ depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH
help
Say Y or M here if your system has TI TPS65982 or TPS65983 USB Power
Delivery controller.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] usb: typec: Ensure USB_ROLE_SWITCH is set as a dependency for tps6598x
2020-05-20 15:36 [PATCH v3] usb: typec: Ensure USB_ROLE_SWITCH is set as a dependency for tps6598x Bryan O'Donoghue
@ 2020-05-20 15:43 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2020-05-20 15:43 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: linux-usb, gregkh, shawn.guo
On Wed, May 20, 2020 at 04:36:17PM +0100, Bryan O'Donoghue wrote:
> When I switched on USB role switching for the tps6598x I completely forgot
> to add the Kconfig dependency.
>
> Ensure USB_ROLE_SWITCH is selected to prevent the typs6598x driver being
> compiled in but the role-switch driver being compiled as a module, leading
> to link error.
>
> Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
> index b4f2aac7ae8a..559dd06117e7 100644
> --- a/drivers/usb/typec/Kconfig
> +++ b/drivers/usb/typec/Kconfig
> @@ -64,7 +64,8 @@ config TYPEC_HD3SS3220
> config TYPEC_TPS6598X
> tristate "TI TPS6598x USB Power Delivery controller driver"
> depends on I2C
> - select REGMAP_I2C
> + depends on REGMAP_I2C
> + depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH
> help
> Say Y or M here if your system has TI TPS65982 or TPS65983 USB Power
> Delivery controller.
> --
> 2.25.1
thanks,
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-20 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 15:36 [PATCH v3] usb: typec: Ensure USB_ROLE_SWITCH is set as a dependency for tps6598x Bryan O'Donoghue
2020-05-20 15:43 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).