From: Maxim Levitsky <mlevitsk@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jiri Kosina <trivial@kernel.org>,
linux-usb@vger.kernel.org (open list:THUNDERBOLT DRIVER),
Yehezkel Bernat <YehezkelShB@gmail.com>,
Maxim Levitsky <mlevitsk@redhat.com>
Subject: [PATCH 1/1] thunderbolt: add trivial .shutdown
Date: Wed, 20 May 2020 21:52:21 +0300 [thread overview]
Message-ID: <20200520185221.122283-2-mlevitsk@redhat.com> (raw)
In-Reply-To: <20200520185221.122283-1-mlevitsk@redhat.com>
On my machine, a kexec with this driver loaded in the old kernel
causes a very long delay on boot in the kexec'ed kernel,
most likely due to unclean shutdown prior to that.
Unloading thunderbolt driver prior to kexec allows kexec to work as fast
as regular kernel boot, as well as adding this .shutdown pointer.
Shutting a device prior to the shutdown completely is always
a good idea IMHO to help with kexec,
and this one-liner patch implements it.
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
---
drivers/thunderbolt/nhi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
index 1be491ecbb45..4046642e6aec 100644
--- a/drivers/thunderbolt/nhi.c
+++ b/drivers/thunderbolt/nhi.c
@@ -1285,6 +1285,7 @@ static struct pci_driver nhi_driver = {
.id_table = nhi_ids,
.probe = nhi_probe,
.remove = nhi_remove,
+ .shutdown = nhi_remove,
.driver.pm = &nhi_pm_ops,
};
--
2.25.4
next prev parent reply other threads:[~2020-05-20 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 18:52 [PATCH 0/1] RFC: Make thunderbolt NHI driver work with kexec [RESEND] Maxim Levitsky
2020-05-20 18:52 ` Maxim Levitsky [this message]
2020-05-25 8:53 ` [PATCH 1/1] thunderbolt: add trivial .shutdown Mika Westerberg
-- strict thread matches above, loose matches on Subject: below --
2020-05-20 18:12 [PATCH 0/1] RFC: Make thunderbolt NHI driver work with kexec Maxim Levitsky
2020-05-20 18:12 ` [PATCH 1/1] thunderbolt: add trivial .shutdown Maxim Levitsky
2020-05-20 18:45 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520185221.122283-2-mlevitsk@redhat.com \
--to=mlevitsk@redhat.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).