Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] USB: serial: qcserial: Add DW5816e QDL support
@ 2020-05-21  0:43 Matt Jolly
  2020-05-25  9:39 ` Johan Hovold
  0 siblings, 1 reply; 3+ messages in thread
From: Matt Jolly @ 2020-05-21  0:43 UTC (permalink / raw)
  To: Johan Hovold, Greg Kroah-Hartman, linux-usb, linux-kernel; +Cc: Matt Jolly

Add support for Dell Wireless 5816e Download Mode (AKA boot & hold mode /
QDL download mode) to drivers/usb/serial/qcserial.c

This is required to update device firmware.

Signed-off-by: Matt Jolly <Kangie@footclan.ninja>
---
v2 changes: typo.
---
drivers/usb/serial/qcserial.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index ce0401d3137f..d147feae83e6 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -173,6 +173,7 @@ static const struct usb_device_id id_table[] = {
 	{DEVICE_SWI(0x413c, 0x81b3)},	/* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
 	{DEVICE_SWI(0x413c, 0x81b5)},	/* Dell Wireless 5811e QDL */
 	{DEVICE_SWI(0x413c, 0x81b6)},	/* Dell Wireless 5811e QDL */
+	{DEVICE_SWI(0x413c, 0x81cb)},	/* Dell Wireless 5816e QDL */
 	{DEVICE_SWI(0x413c, 0x81cc)},	/* Dell Wireless 5816e */
 	{DEVICE_SWI(0x413c, 0x81cf)},   /* Dell Wireless 5819 */
 	{DEVICE_SWI(0x413c, 0x81d0)},   /* Dell Wireless 5819 */
-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] USB: serial: qcserial: Add DW5816e QDL support
  2020-05-21  0:43 [PATCH v2] USB: serial: qcserial: Add DW5816e QDL support Matt Jolly
@ 2020-05-25  9:39 ` Johan Hovold
  2020-05-25 10:33   ` Matt Jolly
  0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2020-05-25  9:39 UTC (permalink / raw)
  To: Matt Jolly; +Cc: Johan Hovold, Greg Kroah-Hartman, linux-usb, linux-kernel

On Thu, May 21, 2020 at 10:43:58AM +1000, Matt Jolly wrote:
> Add support for Dell Wireless 5816e Download Mode (AKA boot & hold mode /
> QDL download mode) to drivers/usb/serial/qcserial.c
> 
> This is required to update device firmware.
> 
> Signed-off-by: Matt Jolly <Kangie@footclan.ninja>
> ---
> v2 changes: typo.

Hmm. I'd a call a build breakage a bit more than just a "typo" as it
indicates this patch was never tested at all before being submitted. 

Not good.

> ---
> drivers/usb/serial/qcserial.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> index ce0401d3137f..d147feae83e6 100644
> --- a/drivers/usb/serial/qcserial.c
> +++ b/drivers/usb/serial/qcserial.c
> @@ -173,6 +173,7 @@ static const struct usb_device_id id_table[] = {
>  	{DEVICE_SWI(0x413c, 0x81b3)},	/* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
>  	{DEVICE_SWI(0x413c, 0x81b5)},	/* Dell Wireless 5811e QDL */
>  	{DEVICE_SWI(0x413c, 0x81b6)},	/* Dell Wireless 5811e QDL */
> +	{DEVICE_SWI(0x413c, 0x81cb)},	/* Dell Wireless 5816e QDL */
>  	{DEVICE_SWI(0x413c, 0x81cc)},	/* Dell Wireless 5816e */
>  	{DEVICE_SWI(0x413c, 0x81cf)},   /* Dell Wireless 5819 */
>  	{DEVICE_SWI(0x413c, 0x81d0)},   /* Dell Wireless 5819 */

Now applied, though.

Johan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] USB: serial: qcserial: Add DW5816e QDL support
  2020-05-25  9:39 ` Johan Hovold
@ 2020-05-25 10:33   ` Matt Jolly
  0 siblings, 0 replies; 3+ messages in thread
From: Matt Jolly @ 2020-05-25 10:33 UTC (permalink / raw)
  To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel

> On 25/5/20 7:39 pm, Johan Hovold wrote:
>> Hmm. I'd a call a build breakage a bit more than just a "typo" as it
>> indicates this patch was never tested at all before being submitted.
I applied, built, and tested it against the sources for the kernel I run 
on my machine, but made several silly mistakes: both manually applying 
the patch to my copy of the repo (which is not my running kernel), and 
not build testing that change before submission. Not good indeed.

I could definitely have been more descriptive in the change notes.

Consider me appropriately chastised!


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-21  0:43 [PATCH v2] USB: serial: qcserial: Add DW5816e QDL support Matt Jolly
2020-05-25  9:39 ` Johan Hovold
2020-05-25 10:33   ` Matt Jolly

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git