From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, Bin Liu <b-liu@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] usb: musb: Fix runtime PM imbalance on error
Date: Fri, 22 May 2020 07:12:22 +0200 [thread overview]
Message-ID: <20200522051222.GA523130@kroah.com> (raw)
In-Reply-To: <20200522025902.11516-1-dinghao.liu@zju.edu.cn>
On Fri, May 22, 2020 at 10:59:02AM +0800, Dinghao Liu wrote:
> When copy_from_user() returns an error code, there
> is a runtime PM usage counter imbalance.
>
> Fix this by moving copy_from_user() to the beginning
> of this function.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/usb/musb/musb_debugfs.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
What changed from v1? Always show that below the --- line as the
documentation says to.
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-22 5:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 2:59 [PATCH] [v2] usb: musb: Fix runtime PM imbalance on error Dinghao Liu
2020-05-22 5:12 ` Greg Kroah-Hartman [this message]
2020-05-22 5:22 ` dinghao.liu
2020-05-22 5:32 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522051222.GA523130@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=b-liu@ti.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).