From: Greg KH <gregkh@linuxfoundation.org>
To: "Diego Elio Pettenò" <flameeyes@flameeyes.com>
Cc: linux-usb@vger.kernel.org, Pete Zaitcev <zaitcev@redhat.com>,
Paolo Abeni <pabeni@redhat.com>,
Kris Katterjohn <katterjohn@gmail.com>
Subject: Re: [PATCH v4 2/2] usbmon: expose the usbmon structures and constants as an UAPI header.
Date: Thu, 9 Jul 2020 18:04:23 +0200 [thread overview]
Message-ID: <20200709160423.GB863447@kroah.com> (raw)
In-Reply-To: <20200706224415.2854-2-flameeyes@flameeyes.com>
On Mon, Jul 06, 2020 at 11:44:15PM +0100, Diego Elio Pettenò wrote:
> This allows applications to use the usbmon ioctl() without declaring the
> constants.
>
> Update the documentation to reflect the new header.
>
> Cc: linux-usb@vger.kernel.org
> Cc: Pete Zaitcev <zaitcev@redhat.com>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Kris Katterjohn <katterjohn@gmail.com>
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Signed-off-by: Diego Elio Pettenò <flameeyes@flameeyes.com>
> ---
> Documentation/usb/usbmon.rst | 70 ++++++++++++-----------
> drivers/usb/mon/mon_bin.c | 92 +-----------------------------
> include/uapi/linux/usb/mon.h | 107 +++++++++++++++++++++++++++++++++++
> 3 files changed, 145 insertions(+), 124 deletions(-)
> create mode 100644 include/uapi/linux/usb/mon.h
What changed from previous versions? Always put that below the --- line
like the documentation asks you to. Please do that when you resend
this series.
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-09 16:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 15:02 [PATCH] usbmon: expose the usbmon structures and constants as an UAPI header Diego Elio Pettenò
2020-07-06 3:51 ` Pete Zaitcev
2020-07-06 8:32 ` Diego Elio Pettenò
2020-07-06 15:01 ` Pete Zaitcev
2020-07-06 5:46 ` kernel test robot
2020-07-06 10:30 ` Greg KH
2020-07-06 12:21 ` Diego Elio Pettenò
2020-07-06 12:15 ` [PATCH v2] " Diego Elio Pettenò
2020-07-06 12:49 ` Greg KH
2020-07-06 13:10 ` Diego Elio Pettenò
2020-07-06 16:15 ` Pete Zaitcev
2020-07-06 13:10 ` [PATCH v3 1/2] Remove documentation line that adds nothing and sounds condescending Diego Elio Pettenò
2020-07-06 13:10 ` [PATCH v3 2/2] usbmon: expose the usbmon structures and constants as an UAPI header Diego Elio Pettenò
2020-07-06 16:35 ` Greg KH
2020-07-06 16:34 ` [PATCH v3 1/2] Remove documentation line that adds nothing and sounds condescending Greg KH
2020-07-06 22:44 ` [PATCH v4 " Diego Elio Pettenò
2020-07-06 22:44 ` [PATCH v4 2/2] usbmon: expose the usbmon structures and constants as an UAPI header Diego Elio Pettenò
2020-07-09 16:04 ` Greg KH [this message]
2020-07-11 13:14 ` kernel test robot
2020-07-09 16:03 ` [PATCH v4 1/2] Remove documentation line that adds nothing and sounds condescending Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709160423.GB863447@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=flameeyes@flameeyes.com \
--cc=katterjohn@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).