From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Kyle Tso <kyletso@google.com>
Cc: linux@roeck-us.net, gregkh@linuxfoundation.org,
badhri@google.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: typec: Comment correction for typec_partner_register_altmode
Date: Tue, 28 Jul 2020 14:56:15 +0300 [thread overview]
Message-ID: <20200728115615.GD883641@kuha.fi.intel.com> (raw)
In-Reply-To: <20200714033453.4044482-2-kyletso@google.com>
On Tue, Jul 14, 2020 at 11:34:52AM +0800, Kyle Tso wrote:
> typec_register_altmode returns ERR_PTR on failure.
>
> Signed-off-by: Kyle Tso <kyletso@google.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/class.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index c9234748537a..02655694f200 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -580,7 +580,7 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);
> * SVID listed in response to Discover Modes command need to be listed in an
> * array in @desc.
> *
> - * Returns handle to the alternate mode on success or NULL on failure.
> + * Returns handle to the alternate mode on success or ERR_PTR on failure.
> */
> struct typec_altmode *
> typec_partner_register_altmode(struct typec_partner *partner,
> --
> 2.27.0.389.gc38d7665816-goog
--
heikki
next prev parent reply other threads:[~2020-07-28 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 3:34 [PATCH 0/2] tcpm: Error handling for tcpm_register_partner_altmodes Kyle Tso
2020-07-14 3:34 ` [PATCH 1/2] usb: typec: Comment correction for typec_partner_register_altmode Kyle Tso
2020-07-14 6:48 ` Guenter Roeck
2020-07-28 11:56 ` Heikki Krogerus [this message]
2020-07-14 3:34 ` [PATCH 2/2] usb: typec: tcpm: Error handling for tcpm_register_partner_altmodes Kyle Tso
2020-07-14 6:49 ` Guenter Roeck
2020-07-28 11:56 ` Heikki Krogerus
2020-07-14 6:02 ` [PATCH 0/2] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728115615.GD883641@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).