From: Greg KH <gregkh@linuxfoundation.org>
To: Christian.Gromm@microchip.com
Cc: driverdev-devel@linuxdriverproject.org, linux-usb@vger.kernel.org
Subject: Re: [RESEND PATCH v5] drivers: most: add USB adapter driver
Date: Wed, 29 Jul 2020 16:57:41 +0200 [thread overview]
Message-ID: <20200729145741.GA3501473@kroah.com> (raw)
In-Reply-To: <799deccc9cd874a2f36bbe93f9b880eea018197f.camel@microchip.com>
On Wed, Jul 29, 2020 at 02:53:29PM +0000, Christian.Gromm@microchip.com wrote:
> On Wed, 2020-07-29 at 16:27 +0200, Greg KH wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >
> > On Mon, Jul 27, 2020 at 10:30:46AM +0200, Christian Gromm wrote:
> > > This patch adds the usb driver source file most_usb.c and
> > > modifies the Makefile and Kconfig accordingly.
> > >
> > > Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
> >
> > Sorry for the long delay in getting to this.
> >
> > This looks good to me, but I tried to apply it to my usb tree, and of
> > course I get the following build error:
> > error: the following would cause module name conflict:
> > drivers/staging/most/usb/most_usb.ko
> > drivers/most/most_usb.ko
> >
> > So, can you just send a "rename the file" patch that I can apply
> > against
> > my staging-next branch and I will take it through there so that there
> > are no conflicts like this?
>
> Are you talking about (1) a patch that just renames the most_usb.ko
> file located at drivers/staging/most/usb/ or (2) a patch for the
> Makefile in the staging tree, so the Kbuild system creates a new
> kernel object in this branch with a different name?
(1) is easiest, do it all at once :)
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-29 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 8:30 [RESEND PATCH v5] drivers: most: add USB adapter driver Christian Gromm
2020-07-27 14:59 ` Randy Dunlap
2020-07-28 7:19 ` Christian.Gromm
2020-07-29 14:27 ` Greg KH
2020-07-29 14:53 ` Christian.Gromm
2020-07-29 14:57 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-01 11:46 Christian Gromm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729145741.GA3501473@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Christian.Gromm@microchip.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).