From: Alan Stern <stern@rowland.harvard.edu>
To: Eli Billauer <eli.billauer@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
hdegoede@redhat.com, oneukum@suse.de
Subject: Re: [PATCH v4] usb: core: Solve race condition in anchor cleanup functions
Date: Thu, 30 Jul 2020 11:28:18 -0400 [thread overview]
Message-ID: <20200730152818.GA7241@rowland.harvard.edu> (raw)
In-Reply-To: <5F22E3C7.1030305@gmail.com>
On Thu, Jul 30, 2020 at 06:14:15PM +0300, Eli Billauer wrote:
> On 30/07/20 17:46, Alan Stern wrote:
> > This loop ought to have a cpu_relax() somewhere, probably here. Same
> > for the other two functions. Otherwise this looks okay to me.
> This function isn't so well documented. Does it go with an include file?
> asm/processor.h, for example? Or just add the call?
asm/processor.h is the appropriate include file, but you can just add
the call without worrying about it. Among other places, asm/processor.h
is included by linux/mutex.h, for example.
Alan Stern
prev parent reply other threads:[~2020-07-30 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 14:18 [PATCH v4] usb: core: Solve race condition in anchor cleanup functions eli.billauer
2020-07-30 14:46 ` Alan Stern
2020-07-30 15:14 ` Eli Billauer
2020-07-30 15:28 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730152818.GA7241@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=eli.billauer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).