From: Nathan Chancellor <natechancellor@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: s3c: Remove unused 'udc' variable
Date: Fri, 31 Jul 2020 11:38:54 -0700 [thread overview]
Message-ID: <20200731183854.GA2279514@ubuntu-n2-xlarge-x86> (raw)
In-Reply-To: <20200731074122.6484-1-krzk@kernel.org>
On Fri, Jul 31, 2020 at 09:41:22AM +0200, Krzysztof Kozlowski wrote:
> Remove unused 'udc' variable to fix compile warnings:
>
> drivers/usb/gadget/udc/s3c2410_udc.c: In function 's3c2410_udc_dequeue':
> drivers/usb/gadget/udc/s3c2410_udc.c:1268:22: warning: variable 'udc' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Weird, looks like it has been unused since the introduction of the
driver.
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/usb/gadget/udc/s3c2410_udc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c
> index bc2e8eb737c3..e875a0b967c0 100644
> --- a/drivers/usb/gadget/udc/s3c2410_udc.c
> +++ b/drivers/usb/gadget/udc/s3c2410_udc.c
> @@ -1270,7 +1270,6 @@ static int s3c2410_udc_queue(struct usb_ep *_ep, struct usb_request *_req,
> static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req)
> {
> struct s3c2410_ep *ep = to_s3c2410_ep(_ep);
> - struct s3c2410_udc *udc;
> int retval = -EINVAL;
> unsigned long flags;
> struct s3c2410_request *req = NULL;
> @@ -1283,8 +1282,6 @@ static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req)
> if (!_ep || !_req)
> return retval;
>
> - udc = to_s3c2410_udc(ep->gadget);
> -
> local_irq_save(flags);
>
> list_for_each_entry(req, &ep->queue, queue) {
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-07-31 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 7:41 [PATCH] usb: gadget: s3c: Remove unused 'udc' variable Krzysztof Kozlowski
2020-07-31 18:38 ` Nathan Chancellor [this message]
2020-08-19 19:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731183854.GA2279514@ubuntu-n2-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=balbi@kernel.org \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).