linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "M. Vefa Bicakci" <m.v.b@runbox.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
	Bastien Nocera <hadess@hadess.net>,
	linux-usb@vger.kernel.org, stable@vger.kernel.org,
	Valentina Manea <valentina.manea.m@gmail.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] usbip: Implement a match function to fix usbip
Date: Wed, 12 Aug 2020 08:16:00 +0200	[thread overview]
Message-ID: <20200812061600.GH1299081@kroah.com> (raw)
In-Reply-To: <99330f61-ed16-7e27-6852-d3486f331ef5@runbox.com>

On Wed, Aug 12, 2020 at 08:47:20AM +0300, M. Vefa Bicakci wrote:
> On 10/08/2020 22.09, Shuah Khan wrote:
> > On 8/10/20 11:31 AM, Bastien Nocera wrote:
> > > On Mon, 2020-08-10 at 19:00 +0300, M. Vefa Bicakci wrote:
> > > > Commit 88b7381a939d ("USB: Select better matching USB drivers when
> > > > available") introduced the use of a "match" function to select a
> > > > non-generic/better driver for a particular USB device. This
> > > > unfortunately breaks the operation of usbip in general, as reported
> > > > in
> > > > the kernel bugzilla with bug 208267 (linked below).
> > > > 
> > > > Upon inspecting the aforementioned commit, one can observe that the
> > > > original code in the usb_device_match function used to return 1
> > > > unconditionally, but the aforementioned commit makes the
> > > > usb_device_match
> > > > function use identifier tables and "match" virtual functions, if
> > > > either of
> > > > them are available.
> > > > 
> > > > Hence, this commit implements a match function for usbip that
> > > > unconditionally returns true to ensure that usbip is functional
> > > > again.
> > > > 
> > > > This change has been verified to restore usbip functionality, with a
> > > > v5.7.y kernel on an up-to-date version of Qubes OS 4.0, which uses
> > > > usbip to redirect USB devices between VMs.
> > > > 
> > > > Thanks to Jonathan Dieter for the effort in bisecting this issue down
> > > > to the aforementioned commit.
> > > 
> > > Looks correct. Thanks for root causing the problem.
> > > 
> > > Reviewed-by: Bastien Nocera <hadess@hadess.net>
> > > 
> > 
> > Thank you for finding and fixing the problem.
> > 
> > Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> 
> Hello Shuah and Bastien,
> 
> Thank you for reviewing the patch!
> 
> Just to confirm, should I re-publish this patch after having added your
> Reviewed-by tags to the commit message? My current understanding is that
> a re-spin of a patch is only necessary when changes are requested during
> the code review. The development process documentation in the kernel
> repository does not mention this aspect, but I might have missed it during
> my quick search.

No need to resend it, my tools will pick up these reviewed-by tags and
add it to the final patch when I apply it.

See the tool 'b4' if you are curious as to how that works.

thanks,

greg k-h

      reply	other threads:[~2020-08-12  6:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 16:00 [PATCH] usbip: Implement a match function to fix usbip M. Vefa Bicakci
2020-08-10 17:31 ` Bastien Nocera
2020-08-10 19:09   ` Shuah Khan
2020-08-12  5:47     ` M. Vefa Bicakci
2020-08-12  6:16       ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200812061600.GH1299081@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hadess@hadess.net \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.v.b@runbox.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).