From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Felipe Balbi <balbi@kernel.org>, Raymond Tan <raymond.tan@intel.com>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/2] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality
Date: Thu, 20 Aug 2020 16:07:37 +0300 [thread overview]
Message-ID: <20200820130737.GA3362430@kuha.fi.intel.com> (raw)
In-Reply-To: <87a6ytzaex.fsf@kernel.org>
On Mon, Aug 17, 2020 at 04:09:26PM +0300, Felipe Balbi wrote:
> Raymond Tan <raymond.tan@intel.com> writes:
>
> > Similar to some other IA platforms, Elkhart Lake too depends on the PMU
> > register write to request transition of Dx power state.
> >
> > Thus, we add the PCI_DEVICE_ID_INTEL_EHL to the list of devices that shall
> > execute the ACPI _DSM method during D0/D3 sequence.
> >
> > Signed-off-by: Raymond Tan <raymond.tan@intel.com>
> > ---
> > drivers/usb/dwc3/dwc3-pci.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> > index 4f436b3..4d50187 100644
> > --- a/drivers/usb/dwc3/dwc3-pci.c
> > +++ b/drivers/usb/dwc3/dwc3-pci.c
> > @@ -149,7 +149,8 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc)
> >
> > if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
> > if (pdev->device == PCI_DEVICE_ID_INTEL_BXT ||
> > - pdev->device == PCI_DEVICE_ID_INTEL_BXT_M) {
> > + pdev->device == PCI_DEVICE_ID_INTEL_BXT_M ||
> > + pdev->device == PCI_DEVICE_ID_INTEL_EHL) {
>
> this looks like a bug fix which could be added during -rc cycle. As
> such, it should be patch 1 in this series. Renaming the macro is less
> critical. Can you update your series so I can take patch 1 during -rc
> and patch 2 for next merge window? Please, don't forget to add the
> Fixes: tag ;-)
Raymond, I'll take care of this patch (and the other one too). I have
now some changes that need to be made on top of this patch, and I
don't want to wait with them anymore, so I'll include these in my
series.
thanks,
--
heikki
prev parent reply other threads:[~2020-08-20 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 18:11 [PATCH 0/2] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality Raymond Tan
2020-08-03 18:11 ` [PATCH 1/2] usb: dwc3: pci: Fix DEFINE for Intel Elkhart Lake Raymond Tan
2020-08-03 18:11 ` [PATCH 2/2] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality Raymond Tan
2020-08-17 13:09 ` Felipe Balbi
2020-08-20 13:07 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820130737.GA3362430@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=raymond.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).