From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Felipe Balbi <balbi@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:"
<linux-usb@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 1/3] software node: Power management operations for software nodes
Date: Mon, 28 Sep 2020 14:32:20 +0300 [thread overview]
Message-ID: <20200928113220.GA3987353@kuha.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0jT7Xdcm1WVvAV9okkoicnEsFEvnLSLLNx6eJHMNxwX+Q@mail.gmail.com>
On Fri, Sep 25, 2020 at 05:54:37PM +0200, Rafael J. Wysocki wrote:
> On Tue, Aug 25, 2020 at 3:59 PM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > Adding separate PM operations vector for the software nodes.
> > The software node specific PM operations make it possible to
> > handle most PM related quirks separately in their own
> > functions instead of conditionally in the device driver's
> > generic PM functions (and in some cases all over the
> > driver). The software node specific PM operations will also
> > reduce the need to pass platform data in some cases, for
> > example from a core MFD driver to the child device drivers,
> > as from now on the core MFD driver will be able to implement
> > the PM quirks directly for the child devices without the
> > need to touch the drivers of those child devices.
> >
> > If a software node includes the PM operations, those PM
> > operations are always executed separately on top of the
> > other PM operations of the device, so the software node will
> > never replace any of the "normal" PM operations of the
> > device (including the PM domain's operations, class's or
> > bus's PM operations, the device drivers own operations, or
> > any other).
>
> This isn't consistent with the code changes AFAICS.
>
> The swnode PM operations are implemented as a PM domain ops, which
> means that they will be executed instead of any other existing ops
> rather than in addition to those.
>
> For example, software_node_prepare() will skip bus type ops if they
> are present and there is no "primary" PM domain which seems not
> intended.
True. I thought the pm_generic_*() functions will take care of also
the bus ops, but of course they don't do that.
> Also some comments might help to understand the design.
OK.
thanks,
--
heikki
next prev parent reply other threads:[~2020-09-28 11:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 13:59 [PATCH 0/3] PM operations for software nodes Heikki Krogerus
2020-08-25 13:59 ` [PATCH 1/3] software node: Power management " Heikki Krogerus
2020-09-25 15:54 ` Rafael J. Wysocki
2020-09-28 11:32 ` Heikki Krogerus [this message]
2020-08-25 13:59 ` [PATCH 2/3] software node: Introduce device_add_software_node() Heikki Krogerus
2020-08-25 14:32 ` Andy Shevchenko
2020-08-25 14:33 ` Andy Shevchenko
2020-08-25 13:59 ` [PATCH 3/3] usb: dwc3: pci: Register a software node for the dwc3 platform device Heikki Krogerus
2020-08-25 14:39 ` [PATCH 0/3] PM operations for software nodes Andy Shevchenko
2020-09-16 13:27 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928113220.GA3987353@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balbi@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).