From: Rob Herring <firstname.lastname@example.org> To: Badhri Jagan Sridharan <email@example.com> Cc: Guenter Roeck <firstname.lastname@example.org>, Heikki Krogerus <email@example.com>, Greg Kroah-Hartman <firstname.lastname@example.org>, Lee Jones <email@example.com>, Mark Brown <firstname.lastname@example.org>, Maxime Ripard <email@example.com>, Alexandre Belloni <firstname.lastname@example.org>, Thierry Reding <email@example.com>, Prashant Malani <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v9 05/15] dt-bindings: connector: Add property to set initial current cap for FRS Date: Tue, 6 Oct 2020 13:29:40 -0500 [thread overview] Message-ID: <20201006182940.GA2574941@bogus> (raw) In-Reply-To: <firstname.lastname@example.org> On Mon, Sep 28, 2020 at 07:39:54PM -0700, Badhri Jagan Sridharan wrote: > This change adds frs-typec-current which allows setting the initial current > capability of the new source when vSafe5V is applied during PD3.0 > sink Fast Role Swap. Shouldn't you Cc the person you copied this from? > Signed-off-by: Badhri Jagan Sridharan <email@example.com> > --- > Changes since v1: > - Changing patch version to v6 to fix version number confusion. > > Changes since v6: > - Removed the redundant usb-connector.txt that I created by mistake. > - Moved to yaml. > > Changes since v7: > - Rebase > > Changes since v8: > - Redefine new-source-frs-typec-current as string enums to address > Rob Herring's comment. > --- > .../bindings/connector/usb-connector.yaml | 26 +++++++++++++++++++ > include/dt-bindings/usb/pd.h | 10 +++++++ > 2 files changed, 36 insertions(+) > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > index 9bd52e63c935..0b8cd08a8678 100644 > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > @@ -142,6 +142,32 @@ properties: > required: > - port@0 > > + new-source-frs-typec-current: > + description: Initial current capability of the new source when vSafe5V > + is applied during PD3.0 Fast Role Swap. "Table 6-14 Fixed Supply PDO - Sink" > + of "USB Power Delivery Specification Revision 3.0, Version 1.2" provides the > + different power levels and "18.104.22.168.1.6 Fast Role Swap USB Type-C Current" > + provides a detailed description of the field. The sink PDO from current source > + reflects the current source's(i.e. transmitter of the FRS signal) power > + requirement during fr swap. The current sink (i.e. receiver of the FRS signal), > + a.k.a new source, should check if it will be able to satisfy the current source's, > + new sink's, requirement during frswap before enabling the frs signal reception. > + This property refers to maximum current capability that the current sink can > + satisfy. During FRS, VBUS voltage is at 5V, as the partners are in implicit > + contract, hence, the power level is only a function of the current capability. > + "not-supported" implies sink to source fast role swap not supported. > + "default" refers to default USB power level as described by > + "Table 6-14 Fixed Supply PDO - Sink". > + "1.5A" refers to 1.5A@5V. > + "3.0A" refers to 3.0A@5V. > + > + $ref: /schemas/types.yaml#/definitions/string > + enum: > + - not-supported > + - default > + - 1.5A > + - 3.0A What happens if the property is not present? I'm not crazy about mixing strings and what could be a number. > + > required: > - compatible > > diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h > index 985f2bbd4d24..db1ad4532197 100644 > --- a/include/dt-bindings/usb/pd.h > +++ b/include/dt-bindings/usb/pd.h > @@ -35,6 +35,16 @@ > > #define VSAFE5V 5000 /* mv units */ > > +/* > + * Based on "Table 6-14 Fixed Supply PDO - Sink" of "USB Power Delivery Specification Revision 3.0, > + * Version 1.2" > + * Initial current capability of the new source when vSafe5V is applied. > + */ > +#define FRS_NOT_SUPPORTED 0 > +#define FRS_DEFAULT_POWER 1 > +#define FRS_5V_1P5A 2 > +#define FRS_5V_3A 3 Why are these in a DT header, but not used by the binding? Though perhaps they should be. Are these numbers from the spec or made up? > + > #define PDO_BATT_MAX_VOLT_SHIFT 20 /* 50mV units */ > #define PDO_BATT_MIN_VOLT_SHIFT 10 /* 50mV units */ > #define PDO_BATT_MAX_PWR_SHIFT 0 /* 250mW units */ > -- > 22.214.171.1249.gb0816b6eb0-goog >
next prev parent reply other threads:[~2020-10-06 18:29 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-29 2:39 [PATCH v9 00/15] TCPM support for FRS and AutoDischarge Disconnect Badhri Jagan Sridharan 2020-09-29 2:39 ` [PATCH v9 01/15] usb: typec: tcpci: Add a getter method to retrieve tcpm_port reference Badhri Jagan Sridharan 2020-09-29 2:39 ` [PATCH v9 02/15] usb: typec: tcpci: Add set_vbus tcpci callback Badhri Jagan Sridharan 2020-10-02 13:39 ` Greg Kroah-Hartman 2020-10-02 13:40 ` Greg Kroah-Hartman 2020-10-02 16:08 ` Badhri Jagan Sridharan 2020-10-03 15:57 ` Greg Kroah-Hartman 2020-10-08 6:32 ` Badhri Jagan Sridharan 2020-09-29 2:39 ` [PATCH v9 03/15] dt-bindings: usb: Maxim type-c controller device tree binding document Badhri Jagan Sridharan 2020-10-05 14:46 ` Rob Herring 2020-10-08 0:42 ` Badhri Jagan Sridharan 2020-10-13 13:43 ` Rob Herring 2020-10-13 13:50 ` Rob Herring 2020-10-20 6:16 ` Badhri Jagan Sridharan 2020-09-29 2:39 ` [PATCH v9 04/15] usb: typec: tcpci_maxim: Chip level TCPC driver Badhri Jagan Sridharan 2020-09-29 2:39 ` [PATCH v9 05/15] dt-bindings: connector: Add property to set initial current cap for FRS Badhri Jagan Sridharan 2020-10-06 18:29 ` Rob Herring [this message] 2020-10-08 1:06 ` Badhri Jagan Sridharan 2020-10-13 14:15 ` Rob Herring 2020-10-20 9:43 ` Badhri Jagan Sridharan 2020-09-29 2:39 ` [PATCH v9 06/15] usb: typec: tcpm: Add support for Sink Fast Role SWAP(FRS) Badhri Jagan Sridharan 2020-09-29 2:39 ` [PATCH v9 07/15] usb: typec: tcpci: Implement callbacks for FRS Badhri Jagan Sridharan 2020-09-29 2:39 ` [PATCH v9 08/15] usb: typec: tcpci_maxim: Add support for Sink FRS Badhri Jagan Sridharan 2020-09-29 2:39 ` [PATCH v9 09/15] usb: typec: tcpm: frs sourcing vbus callback Badhri Jagan Sridharan 2020-09-29 2:39 ` [PATCH v9 10/15] usb: typec: tcpci: " Badhri Jagan Sridharan 2020-09-29 2:40 ` [PATCH v9 11/15] usb: typec: tcpci_max77759: Fix vbus stuck on upon diconnecting sink Badhri Jagan Sridharan 2020-09-29 2:40 ` [PATCH v9 12/15] usb: typec: tcpm: Parse frs type-c current from device tree Badhri Jagan Sridharan 2020-09-29 2:40 ` [PATCH v9 13/15] usb: typec: tcpm: Implement enabling Auto Discharge disconnect support Badhri Jagan Sridharan 2020-09-29 2:40 ` [PATCH v9 14/15] usb: typec: tcpci: Implement Auto discharge disconnect callbacks Badhri Jagan Sridharan 2020-09-29 2:40 ` [PATCH v9 15/15] usb: typec: tcpci_maxim: Enable auto discharge disconnect Badhri Jagan Sridharan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201006182940.GA2574941@bogus \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v9 05/15] dt-bindings: connector: Add property to set initial current cap for FRS' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).