* [PATCH net-next] net: usbnet: remove driver version
@ 2020-10-09 12:10 Heiner Kallweit
2020-10-09 13:08 ` Greg KH
2020-10-10 17:43 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2020-10-09 12:10 UTC (permalink / raw)
To: Oliver Neukum, David Miller, Jakub Kicinski
Cc: Linux USB Mailing List, netdev
Obviously this driver version doesn't make sense. Go with the default
and let ethtool display the kernel version.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/usb/usbnet.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index bf6c58240..963d260d1 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -34,9 +34,6 @@
#include <linux/kernel.h>
#include <linux/pm_runtime.h>
-#define DRIVER_VERSION "22-Aug-2005"
-
-
/*-------------------------------------------------------------------------*/
/*
@@ -1047,7 +1044,6 @@ void usbnet_get_drvinfo (struct net_device *net, struct ethtool_drvinfo *info)
struct usbnet *dev = netdev_priv(net);
strlcpy (info->driver, dev->driver_name, sizeof info->driver);
- strlcpy (info->version, DRIVER_VERSION, sizeof info->version);
strlcpy (info->fw_version, dev->driver_info->description,
sizeof info->fw_version);
usb_make_path (dev->udev, info->bus_info, sizeof info->bus_info);
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: usbnet: remove driver version
2020-10-09 12:10 [PATCH net-next] net: usbnet: remove driver version Heiner Kallweit
@ 2020-10-09 13:08 ` Greg KH
2020-10-10 17:43 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-10-09 13:08 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Oliver Neukum, David Miller, Jakub Kicinski,
Linux USB Mailing List, netdev
On Fri, Oct 09, 2020 at 02:10:57PM +0200, Heiner Kallweit wrote:
> Obviously this driver version doesn't make sense. Go with the default
> and let ethtool display the kernel version.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: usbnet: remove driver version
2020-10-09 12:10 [PATCH net-next] net: usbnet: remove driver version Heiner Kallweit
2020-10-09 13:08 ` Greg KH
@ 2020-10-10 17:43 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-10-10 17:43 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Oliver Neukum, David Miller, Linux USB Mailing List, netdev
On Fri, 9 Oct 2020 14:10:57 +0200 Heiner Kallweit wrote:
> Obviously this driver version doesn't make sense. Go with the default
> and let ethtool display the kernel version.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied, thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-10 22:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-09 12:10 [PATCH net-next] net: usbnet: remove driver version Heiner Kallweit
2020-10-09 13:08 ` Greg KH
2020-10-10 17:43 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).