From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=tQHF=DS=vger.kernel.org=linux-usb-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id DF196C433DF
	for <linux-usb@archiver.kernel.org>; Sun, 11 Oct 2020 22:55:47 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id A68DF20776
	for <linux-usb@archiver.kernel.org>; Sun, 11 Oct 2020 22:55:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1602456947;
	bh=KvDRy898tZkJV1H44iDrW5fdptEiyvUv8AeifK7jE9k=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=VgZVci3bKAh1yBsaF9HxSunrNlHTAxJhDNkheYxX4JbJp9tiGQM7YfrVI5BCSRXHS
	 Q1Yh6Xv5yx5niZktyUEYmNF2GVOjYLKsHQtMaqnfr0csxZMV2oIMG/KajVjE6WtKbz
	 HWFcBxkK2D6MBguHPlEGfZMLlzcrzWk4M3gUL1bc=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2387780AbgJKWzm (ORCPT <rfc822;linux-usb@archiver.kernel.org>);
        Sun, 11 Oct 2020 18:55:42 -0400
Received: from mail.kernel.org ([198.145.29.99]:34916 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726148AbgJKWzm (ORCPT <rfc822;linux-usb@vger.kernel.org>);
        Sun, 11 Oct 2020 18:55:42 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 899B32076E;
        Sun, 11 Oct 2020 22:55:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1602456941;
        bh=KvDRy898tZkJV1H44iDrW5fdptEiyvUv8AeifK7jE9k=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=Q0mFFIyvRoV278p7Jk5P76lPAglEnFI38QGRWSs8ljqd2iW/PFeTBxkEaljMTDFJX
         1aIXMTh3LDQ3nPAcR5Pq9zsxaGbgo2Cv3Vto0pus0aVfdohHh10BlqyAG/nwsPbQoR
         HCF8yIh0NI4rovD880UL20ZS/djeYJjlQlDErT/c=
Date:   Sun, 11 Oct 2020 15:55:39 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Ondrej Zary <linux@zary.sk>
Cc:     Oliver Neukum <oneukum@suse.com>, netdev@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cx82310_eth: re-enable ethernet mode after router
 reboot
Message-ID: <20201011155539.315bf5aa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201010140048.12067-1-linux@zary.sk>
References: <20201010140048.12067-1-linux@zary.sk>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-usb.vger.kernel.org>
X-Mailing-List: linux-usb@vger.kernel.org

On Sat, 10 Oct 2020 16:00:46 +0200 Ondrej Zary wrote:
> When the router is rebooted without a power cycle, the USB device
> remains connected but its configuration is reset. This results in
> a non-working ethernet connection with messages like this in syslog:
> 	usb 2-2: RX packet too long: 65535 B
> 
> Re-enable ethernet mode when receiving a packet with invalid size of
> 0xffff.

Patch looks good, but could you explain what's a reboot without a power
cycle in this case? The modem gets reset but USB subsystem doesn't know
it and doesn't go though a unbind() + bind() cycle?