From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61AF3C433DF for ; Mon, 12 Oct 2020 16:00:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27D3920776 for ; Mon, 12 Oct 2020 16:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602518446; bh=plJ6uVm5y+4kojV5M8wXWHaYtOVAg2A/pACW5t4gmtM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Bilg5eZyBVYqo9ymFIIQAoxGj+1wEcN6WtCnxEWQYzGQCBet+l65VyOHjgzu0r6qW RemqStO0lcAHKh0M+JZh/Y4FQYhYq+RnTon5PyFVIIs5qL3i+Oo0eUnIPmyurV6MBd SkiJIkCcgYiH3A3A4Ex5gZAIVKgGLvnBW6RTBXr4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389976AbgJLQAl (ORCPT ); Mon, 12 Oct 2020 12:00:41 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:40950 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389771AbgJLQAl (ORCPT ); Mon, 12 Oct 2020 12:00:41 -0400 Received: by mail-ot1-f65.google.com with SMTP id l4so16261663ota.7; Mon, 12 Oct 2020 09:00:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sKQvgCFfoUK383C3nmDjkaV64Iaz4htqCFpPTHjis94=; b=DVGuDgmr7+LBzZaET5scApmNjHjps1RWmBneflL8cIMP36vBlb4m88JvD1NrjbSbN7 2e8hRxt6Fue9Z30muGGYssHYDSIJ2wzoPrJe9OmrCCXW8ChuiJ5s8xX8oEcDF0SvKM1W m4WNy2CcYnP3gL/9rCGnX0WeeH3+97SSfzjrRMze1DXpBOQUEb9M7frQBET8EfHqC4/w lvfJrKhGRfKWqeDq5L2Gr/7aUQ3bSRYf03k5Bdzmcscmrn6Mw7UGblXAZEhmo0NlZrXY QJ5uxjyntzkOeZf7PrqeJb4mGb3+QBqSslIzxyJjMhhQXPf/UEJ5Kxa2lZB3yB2+3a6i CUEA== X-Gm-Message-State: AOAM533m2fRE2pMWHgqg35MZTdz4V8Ex0bGVKP5JRbQ6eriKayMPVBG9 0XbqAQs45UNinatFOpWQFQ== X-Google-Smtp-Source: ABdhPJxkLahxePnE9AL27oE1+P/rxoCNJR5P+a+QdCW4mRzABSit5agAwmV+5vq3bUnnU+pwFw6YXg== X-Received: by 2002:a9d:3e4:: with SMTP id f91mr20173294otf.244.1602518440260; Mon, 12 Oct 2020 09:00:40 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id k73sm8849333otk.63.2020.10.12.09.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 09:00:39 -0700 (PDT) Received: (nullmailer pid 1622059 invoked by uid 1000); Mon, 12 Oct 2020 16:00:38 -0000 Date: Mon, 12 Oct 2020 11:00:38 -0500 From: Rob Herring To: Chunfeng Yun Cc: "David S . Miller" , Jakub Kicinski , Greg Kroah-Hartman , Matthias Brugger , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 2/4] dt-bindings: usb: add properties for hard wired devices Message-ID: <20201012160038.GA1618651@bogus> References: <3db52d534065dcf28e9a10b8129bea3eced0193e.1602318869.git.chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sat, Oct 10, 2020 at 04:43:12PM +0800, Chunfeng Yun wrote: > Add some optional properties which are needed for hard wired devices > > Signed-off-by: Chunfeng Yun > --- > v2 changes suggested by Rob: > 1. modify pattern to support any USB class > 2. refer to usb-device.yaml instead of usb-device.txt > --- > .../devicetree/bindings/usb/usb-hcd.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) You can fold this into the first patch. While not explicit before, it was implied. Rob > > diff --git a/Documentation/devicetree/bindings/usb/usb-hcd.yaml b/Documentation/devicetree/bindings/usb/usb-hcd.yaml > index 7263b7f2b510..42b295afdf32 100644 > --- a/Documentation/devicetree/bindings/usb/usb-hcd.yaml > +++ b/Documentation/devicetree/bindings/usb/usb-hcd.yaml > @@ -22,9 +22,28 @@ properties: > description: > Name specifier for the USB PHY > > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^[a-f]+@[0-9a-f]+$": Just define the unit-address here: "@[0-9a-f]+$" > + type: object > + $ref: /usb/usb-device.yaml > + description: The hard wired USB devices Need to also define 'reg' and 'compatible' here. > + > examples: > - | > usb { > phys = <&usb2_phy1>, <&usb3_phy1>; > phy-names = "usb"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + hub@1 { > + compatible = "usb5e3,610"; > + reg = <1>; > + }; > }; > -- > 2.18.0