From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech,
linux-usb@vger.kernel.org
Subject: Re: [linux-safety] [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error
Date: Tue, 13 Oct 2020 07:21:50 +0200 [thread overview]
Message-ID: <20201013052150.GA330398@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2010122008370.17866@felia>
On Mon, Oct 12, 2020 at 08:17:34PM +0200, Lukas Bulwahn wrote:
> > If you are suggesting some sort of special code annotation that the tool
> > would understand, I am open to that. But I'm not aware of any even
> > vaguely standard way of marking up a particular function call to
> > indicate it will not return an error.
>
> I cannot yet say if some annotation would work, we, Sudip and me, need to
> investigate. It could be that something like, assert(!IS_ERR(tt)), is
> sufficient to let the tools know that they can safely assume that the
> path they are complaining about is not possible.
>
> We could make the assert() a nop, so it would not effect the resulting
> object code in any way.
Things like assert() have been rejected numberous times in the past in
the kernel, good luck with that :)
greg k-h
next prev parent reply other threads:[~2020-10-13 5:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 20:50 [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error Sudip Mukherjee
2020-10-12 0:27 ` Alan Stern
2020-10-12 14:11 ` [linux-safety] " Lukas Bulwahn
2020-10-12 14:57 ` Alan Stern
2020-10-12 15:10 ` Lukas Bulwahn
2020-10-12 15:18 ` Greg Kroah-Hartman
2020-10-12 18:25 ` Lukas Bulwahn
2020-10-13 5:23 ` Greg Kroah-Hartman
2020-10-13 5:37 ` Lukas Bulwahn
2020-10-13 6:36 ` Greg Kroah-Hartman
2020-10-13 7:16 ` Lukas Bulwahn
2020-10-13 7:35 ` Greg Kroah-Hartman
2020-10-13 8:02 ` Lukas Bulwahn
2020-10-13 8:24 ` Sudip Mukherjee
2020-10-13 8:36 ` Lukas Bulwahn
2020-10-12 16:00 ` Alan Stern
2020-10-12 18:17 ` Lukas Bulwahn
2020-10-13 5:21 ` Greg Kroah-Hartman [this message]
2020-10-13 5:41 ` Lukas Bulwahn
2020-10-12 15:24 ` Sudip Mukherjee
2020-10-12 18:49 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013052150.GA330398@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=linux-usb@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).