From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Rob Herring <robh@kernel.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Manu Gautam <mgautam@codeaurora.org>,
Roger Quadros <rogerq@ti.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
<linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes
Date: Tue, 13 Oct 2020 18:50:20 +0300 [thread overview]
Message-ID: <20201013155020.l7uqti25kk3mhdmy@mobilestation> (raw)
In-Reply-To: <20201013124203.GE3269269@bogus>
On Tue, Oct 13, 2020 at 07:42:03AM -0500, Rob Herring wrote:
> On Sun, Oct 11, 2020 at 01:41:19AM +0300, Serge Semin wrote:
> > Amlogic G12A USB DT sub-nodes are supposed to be compatible with the
> > generic DWC USB2 and USB3 devices. Since now we've got DT schemas for
> > both of the later IP cores let's make sure that the Amlogic G12A USB
> > DT nodes are fully evaluated including the DWC sub-nodes.
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > ---
> > .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
> > index 88184d7e26cc..3e8ac0ff90de 100644
> > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
> > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
> > @@ -78,7 +78,20 @@ properties:
> >
> > patternProperties:
> > "^usb@[0-9a-f]+$":
> > - type: object
> > + allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: snps,dwc2
> > + then:
> > + $ref: dwc2.yaml#
> > + - if:
> > + properties:
> > + compatible:
> > + const: snps,dwc3
> > + then:
> > + $ref: snps,dwc3.yaml#
>
> It should be enough to do just:
>
> oneOf:
> - $ref: dwc2.yaml#
> - $ref: snps,dwc3.yaml#
Ah, good point! Thanks.
-Sergey
next prev parent reply other threads:[~2020-10-13 15:50 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 22:41 [PATCH 00/18] dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema Serge Semin
2020-10-10 22:41 ` [PATCH 01/18] dt-bindings: usb: usb-hcd: Convert generic USB properties to " Serge Semin
2020-10-13 12:14 ` Rob Herring
2020-10-13 14:00 ` Serge Semin
2020-10-10 22:41 ` [PATCH 02/18] dt-bindings: usb: usb-hcd: Add "wireless" maximum-speed property value Serge Semin
2020-10-11 14:42 ` Greg Kroah-Hartman
2020-10-11 17:53 ` Serge Semin
2020-10-12 15:41 ` Greg Kroah-Hartman
2020-10-12 21:19 ` Serge Semin
2020-10-10 22:41 ` [PATCH 03/18] dt-bindings: usb: usb-hcd: Add "otg-rev" property restriction Serge Semin
2020-10-10 22:41 ` [PATCH 04/18] dt-bindings: usb: usb-hcd: Add "ulpi/serial/hsic" PHY types Serge Semin
2020-10-11 8:49 ` Sergei Shtylyov
2020-10-11 18:03 ` Serge Semin
2020-10-10 22:41 ` [PATCH 05/18] dt-bindings: usb: usb-hcd: Add "tpl-support" property Serge Semin
2020-10-11 8:47 ` Sergei Shtylyov
2020-10-11 18:05 ` Serge Semin
2020-10-11 18:06 ` Serge Semin
2020-10-10 22:41 ` [PATCH 06/18] dt-bindings: usb: usb-hcd: Add generic "usb-phy" property Serge Semin
2020-10-10 22:41 ` [PATCH 07/18] dt-bindings: usb: Convert xHCI bindings to DT schema Serge Semin
2020-10-13 12:30 ` Rob Herring
2020-10-13 14:29 ` Serge Semin
2020-10-10 22:41 ` [PATCH 08/18] dt-bindings: usb: xhci: Add Broadcom STB v2 compatible device Serge Semin
2020-10-10 22:41 ` [PATCH 09/18] dt-bindings: usb: renesas-xhci: Refer to the usb-xhci.yaml file Serge Semin
2020-10-10 22:41 ` [PATCH 10/18] dt-bindings: usb: Convert DWC USB3 bindings to DT schema Serge Semin
2020-10-13 12:36 ` Rob Herring
2020-10-13 15:16 ` Serge Semin
2020-10-10 22:41 ` [PATCH 11/18] dt-bindings: usb: dwc3: Add interrupt-names property support Serge Semin
2020-10-11 8:53 ` Sergei Shtylyov
2020-10-11 18:09 ` Serge Semin
2020-10-10 22:41 ` [PATCH 12/18] dt-bindings: usb: dwc3: Add synopsys,dwc3 compatible string Serge Semin
2020-10-10 22:41 ` [PATCH 13/18] dt-bindings: usb: dwc3: Add Tx De-emphasis restrictions Serge Semin
2020-10-11 8:56 ` Sergei Shtylyov
2020-10-11 18:14 ` Serge Semin
2020-10-10 22:41 ` [PATCH 14/18] dt-bindings: usb: dwc3: Add Frame Length Adj restrictions Serge Semin
2020-10-13 12:38 ` Rob Herring
2020-10-13 15:45 ` Serge Semin
2020-10-10 22:41 ` [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property Serge Semin
2020-10-12 7:54 ` Neil Armstrong
2020-10-12 14:22 ` Serge Semin
2020-10-12 15:01 ` Neil Armstrong
2020-10-12 15:13 ` Serge Semin
2020-10-12 15:29 ` Neil Armstrong
2020-10-10 22:41 ` [PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes Serge Semin
2020-10-12 7:38 ` Neil Armstrong
2020-10-13 12:42 ` Rob Herring
2020-10-13 15:50 ` Serge Semin [this message]
2020-10-10 22:41 ` [PATCH 17/18] dt-bindings: usb: keystone-dwc3: Validate DWC3 sub-node Serge Semin
2020-10-11 9:04 ` Sergei Shtylyov
2020-10-11 18:18 ` Serge Semin
2020-10-10 22:41 ` [PATCH 18/18] dt-bindings: usb: qcom,dwc3: " Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013155020.l7uqti25kk3mhdmy@mobilestation \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mathias.nyman@intel.com \
--cc=mgautam@codeaurora.org \
--cc=narmstrong@baylibre.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=rogerq@ti.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).