From: zwisler@google.com
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"kernel@collabora.com" <kernel@collabora.com>
Subject: Re: xhci problem -> general protection fault
Date: Tue, 13 Oct 2020 10:44:30 -0600
Message-ID: <20201013164430.GA3633291@google.com> (raw)
In-Reply-To: <48f2e022-1937-6ecc-ad8e-ef293fd2bfe1@collabora.com>
On Tue, Oct 13, 2020 at 10:29:51AM +0200, Andrzej Pietrasiewicz wrote:
> W dniu 13.10.2020 o 09:49, Mathias Nyman pisze:
> > On 13.10.2020 0.53, zwisler@google.com wrote:
> > > On Mon, Oct 12, 2020 at 10:20:31PM +0300, Mathias Nyman wrote:
> > > > On 1.10.2020 19.43, zwisler@google.com wrote:
> > > > > On Tue, Sep 29, 2020 at 01:35:31AM +0300, Mathias Nyman wrote:
> > >
> > > > I'm rewriting how xhci driver handles halted and canceled transfers.
> > > > While looking into it I found an older case where hardware gives bad data
> > > > in the output context. This was 10 years ago and on some specic hardware,
> > > > see commit:
> > > >
> > > > ac9d8fe7c6a8 USB: xhci: Add quirk for Fresco Logic xHCI hardware.
> > > >
> > > > >
> > > > > I'm happy to gather logs with more debug or run other experiments, if that
> > > > > would be helpful. As it is I don't really know how to debug the internal
> > > > > state of the HC further, but hopefully the knowledge that the patch below
> > > > > makes a difference will help us move forward.
> > > >
> > > > Great thanks, it will take some time before rewrite is ready.
> > >
> > > Should we/I invest time in trying to create a quirk similar to
> > >
> > > > ac9d8fe7c6a8 USB: xhci: Add quirk for Fresco Logic xHCI hardware.
> > >
> > > in the mean time, or should we just wait for your rewrite?
> > >
> >
> > I've been focusing on this part so rewrite shouldn't take long.
>
> Thank you for doing that!
>
> Should you be sending your patches not as a reply in this thread
> kindly Cc me andrzej.p@collabora.com.
Please CC me as well, and I'd be happy to test for you. Thanks again!
next prev parent reply index
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 15:30 Andrzej Pietrasiewicz
2020-09-18 10:50 ` Mathias Nyman
2020-09-18 14:20 ` Andrzej Pietrasiewicz
2020-09-25 13:40 ` Mathias Nyman
2020-09-25 21:05 ` Ross Zwisler
2020-09-28 13:32 ` Andrzej Pietrasiewicz
2020-09-29 7:13 ` Mathias Nyman
2020-10-01 14:13 ` Andrzej Pietrasiewicz
2020-09-28 22:35 ` Mathias Nyman
2020-10-01 16:43 ` zwisler
2020-10-12 19:20 ` Mathias Nyman
2020-10-12 21:53 ` zwisler
2020-10-13 7:49 ` Mathias Nyman
2020-10-13 8:29 ` Andrzej Pietrasiewicz
2020-10-13 16:44 ` zwisler [this message]
2020-11-19 16:52 ` Ross Zwisler
2020-11-23 15:06 ` Mathias Nyman
2020-12-02 22:59 ` Ross Zwisler
2020-12-04 18:07 ` Mathias Nyman
2020-12-08 17:24 ` Ross Zwisler
2020-12-09 13:11 ` Mathias Nyman
2020-12-09 18:54 ` Ross Zwisler
2020-12-30 12:33 ` Mathias Nyman
2021-01-06 18:52 ` Ross Zwisler
2021-01-07 8:57 ` Mathias Nyman
2021-01-07 16:07 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013164430.GA3633291@google.com \
--to=zwisler@google.com \
--cc=andrzej.p@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-USB Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
linux-usb@vger.kernel.org
public-inbox-index linux-usb
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git