From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E320EC43467 for ; Wed, 14 Oct 2020 05:42:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9ED632222F for ; Wed, 14 Oct 2020 05:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602654178; bh=w10HAUvHzI4K2dPPA6eBw0IIFtp11qCCa0wUzKaUmD8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Otf5pop1PgUWd8Wl6NuUEWcwkRAKYuw5w35j/zOZJwhVJG84ePpQd7RZAoFJcSi/k dPU4LNWeZEzbFOk3FKBwmso0N691S/KC8wvziUCWb24QqOvR0pSfCSMqg0SUOxAJbT p22JoaqrBZAqTo0cZ5lTRY2ih7/bFHWt7/l40YVU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726290AbgJNFmz (ORCPT ); Wed, 14 Oct 2020 01:42:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:44624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725983AbgJNFmz (ORCPT ); Wed, 14 Oct 2020 01:42:55 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 936BB2177B; Wed, 14 Oct 2020 05:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602654174; bh=w10HAUvHzI4K2dPPA6eBw0IIFtp11qCCa0wUzKaUmD8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cKsoRdZk0/7P9W5KQIcB78oxj7gSK1YWQM+hrVcStVlKqV5euxdawGaIKjsJO+YUU /usInNdGonQCzHNv/4cuzYg3D1kAHdZbtEGHplDqaWK5j6M3yEug5qW6hLhVGcPu6C Ur12VOGAV45LDfAlhlt9kErfzTLPyFZ2XWjKnbEc= Date: Wed, 14 Oct 2020 08:42:50 +0300 From: Leon Romanovsky To: Jakub Kicinski Cc: Heiner Kallweit , David Miller , =?iso-8859-1?Q?Bj=F8rn?= Mork , Oliver Neukum , Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Roopa Prabhu , Nikolay Aleksandrov , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Alexey Kuznetsov , Hideaki YOSHIFUJI , Johannes Berg , Pravin B Shelar , Steffen Klassert , Herbert Xu , "netdev@vger.kernel.org" , linux-rdma@vger.kernel.org, Linux USB Mailing List , linux-wireless , bridge@lists.linux-foundation.org Subject: Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Message-ID: <20201014054250.GB6305@unreal> References: <20201013173951.25677bcc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201013173951.25677bcc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Oct 13, 2020 at 05:39:51PM -0700, Jakub Kicinski wrote: > On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote: > > In several places the same code is used to populate rtnl_link_stats64 > > fields with data from pcpu_sw_netstats. Therefore factor out this code > > to a new function dev_fetch_sw_netstats(). > > > > v2: > > - constify argument netstats > > - don't ignore netstats being NULL or an ERRPTR > > - switch to EXPORT_SYMBOL_GPL > > Applied, thank you! Jakub, Is it possible to make sure that changelogs are not part of the commit messages? We don't store previous revisions in the git repo, so it doesn't give too much to anyone who is looking on git log later. The lore link to the patch is more than enough. 44fa32f008ab ("net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats") Thanks