Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3] usb: cdns3: Variable 'length' set but not used
@ 2020-10-15  4:55 Pawel Laszczak
  2020-10-26  9:47 ` Pawel Laszczak
  0 siblings, 1 reply; 8+ messages in thread
From: Pawel Laszczak @ 2020-10-15  4:55 UTC (permalink / raw)
  To: peter.chen
  Cc: balbi, rogerq, nsekhar, gregkh, linux-usb, linux-kernel, kurahul,
	Pawel Laszczak

Patch removes not used variable 'length' from
cdns3_wa2_descmiss_copy_data function.

Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Acked-by: Roger Quadros <rogerq@ti.com>
---
Changelog:
v3
- added "Acked-by" tag.
v2
- added "Fixes" tag.

 drivers/usb/cdns3/gadget.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
index 6e7b70a2e352..692acf7b9b14 100644
--- a/drivers/usb/cdns3/gadget.c
+++ b/drivers/usb/cdns3/gadget.c
@@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
 
 	while (!list_empty(&priv_ep->wa2_descmiss_req_list)) {
 		int chunk_end;
-		int length;
 
 		descmiss_priv_req =
 			cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list);
@@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
 			break;
 
 		chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH;
-		length = request->actual + descmiss_req->actual;
 		request->status = descmiss_req->status;
 		__cdns3_descmiss_copy_data(request, descmiss_req);
 		list_del_init(&descmiss_priv_req->list);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-15  4:55 [PATCH v3] usb: cdns3: Variable 'length' set but not used Pawel Laszczak
2020-10-26  9:47 ` Pawel Laszczak
2020-10-26 11:55   ` Peter Chen
2020-10-27  3:58     ` Peter Chen
2020-10-27 12:08       ` Pawel Laszczak
2020-10-28  6:44         ` Peter Chen
2020-10-28  7:20           ` Pawel Laszczak
2020-10-28  7:35             ` Peter Chen

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git