From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Thierry Reding <treding@nvidia.com>,
Prashant Malani <pmalani@chromium.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org,
Amelie Delaunay <amelie.delaunay@st.com>
Subject: Re: [PATCH v10 09/15] usb: typec: tcpm: frs sourcing vbus callback
Date: Mon, 19 Oct 2020 16:40:48 +0300 [thread overview]
Message-ID: <20201019134048.GD1667571@kuha.fi.intel.com> (raw)
In-Reply-To: <20201008061556.1402293-10-badhri@google.com>
On Wed, Oct 07, 2020 at 11:15:50PM -0700, Badhri Jagan Sridharan wrote:
> During FRS hardware autonomously starts to source vbus. Provide
> callback to perform chip specific operations.
>
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Introduced in v9. No chages since then.
> ---
> drivers/usb/typec/tcpm/tcpm.c | 9 +++++++++
> include/linux/usb/tcpm.h | 4 ++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 55535c4f66bf..02b7f623f584 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4090,7 +4090,16 @@ static void _tcpm_pd_vbus_on(struct tcpm_port *port)
> case SRC_TRY_DEBOUNCE:
> /* Do nothing, waiting for sink detection */
> break;
> + case FR_SWAP_SEND:
> + case FR_SWAP_SEND_TIMEOUT:
> + case FR_SWAP_SNK_SRC_TRANSITION_TO_OFF:
> + case FR_SWAP_SNK_SRC_SOURCE_VBUS_APPLIED:
> + if (port->tcpc->frs_sourcing_vbus)
> + port->tcpc->frs_sourcing_vbus(port->tcpc);
> + break;
> case FR_SWAP_SNK_SRC_NEW_SINK_READY:
> + if (port->tcpc->frs_sourcing_vbus)
> + port->tcpc->frs_sourcing_vbus(port->tcpc);
> tcpm_set_state(port, FR_SWAP_SNK_SRC_SOURCE_VBUS_APPLIED, 0);
> break;
>
> diff --git a/include/linux/usb/tcpm.h b/include/linux/usb/tcpm.h
> index 09762d26fa0c..7303f518ba49 100644
> --- a/include/linux/usb/tcpm.h
> +++ b/include/linux/usb/tcpm.h
> @@ -83,6 +83,9 @@ enum tcpm_transmit_type {
> * Optional; Called to enable/disable PD 3.0 fast role swap.
> * Enabling frs is accessory dependent as not all PD3.0
> * accessories support fast role swap.
> + * @frs_sourcing_vbus:
> + * Optional; Called to notify that vbus is now being sourced.
> + * Low level drivers can perform chip specific operations, if any.
> */
> struct tcpc_dev {
> struct fwnode_handle *fwnode;
> @@ -109,6 +112,7 @@ struct tcpc_dev {
> const struct pd_message *msg);
> int (*set_bist_data)(struct tcpc_dev *dev, bool on);
> int (*enable_frs)(struct tcpc_dev *dev, bool enable);
> + void (*frs_sourcing_vbus)(struct tcpc_dev *dev);
> };
>
> struct tcpm_port;
> --
> 2.28.0.806.g8561365e88-goog
thanks,
--
heikki
next prev parent reply other threads:[~2020-10-19 13:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 6:15 [PATCH v10 00/15] TCPM support for FRS and AutoDischarge Disconnect Badhri Jagan Sridharan
2020-10-08 6:15 ` [PATCH v10 01/15] usb: typec: tcpci: Add a getter method to retrieve tcpm_port reference Badhri Jagan Sridharan
2020-10-08 6:15 ` [PATCH v10 02/15] usb: typec: tcpci: Add set_vbus tcpci callback Badhri Jagan Sridharan
2020-10-08 6:15 ` [PATCH v10 03/15] dt-bindings: usb: Maxim type-c controller device tree binding document Badhri Jagan Sridharan
2020-10-08 6:15 ` [PATCH v10 04/15] usb: typec: tcpci_maxim: Chip level TCPC driver Badhri Jagan Sridharan
2020-10-08 6:15 ` [PATCH v10 05/15] dt-bindings: connector: Add property to set initial current cap for FRS Badhri Jagan Sridharan
2020-10-08 6:15 ` [PATCH v10 06/15] usb: typec: tcpm: Add support for Sink Fast Role SWAP(FRS) Badhri Jagan Sridharan
2020-10-08 6:15 ` [PATCH v10 07/15] usb: typec: tcpci: Implement callbacks for FRS Badhri Jagan Sridharan
2020-10-08 6:15 ` [PATCH v10 08/15] usb: typec: tcpci_maxim: Add support for Sink FRS Badhri Jagan Sridharan
2020-10-08 6:15 ` [PATCH v10 09/15] usb: typec: tcpm: frs sourcing vbus callback Badhri Jagan Sridharan
2020-10-19 13:40 ` Heikki Krogerus [this message]
2020-10-08 6:15 ` [PATCH v10 10/15] usb: typec: tcpci: " Badhri Jagan Sridharan
2020-10-19 13:41 ` Heikki Krogerus
2020-10-08 6:15 ` [PATCH v10 11/15] usb: typec: tcpci_max77759: Fix vbus stuck on upon diconnecting sink Badhri Jagan Sridharan
2020-10-19 13:44 ` Heikki Krogerus
2020-10-08 6:15 ` [PATCH v10 12/15] usb: typec: tcpm: Parse frs type-c current from device tree Badhri Jagan Sridharan
2020-10-08 6:15 ` [PATCH v10 13/15] usb: typec: tcpm: Implement enabling Auto Discharge disconnect support Badhri Jagan Sridharan
2020-10-19 13:48 ` Heikki Krogerus
2020-10-08 6:15 ` [PATCH v10 14/15] usb: typec: tcpci: Implement Auto discharge disconnect callbacks Badhri Jagan Sridharan
2020-10-19 13:49 ` Heikki Krogerus
2020-10-08 6:15 ` [PATCH v10 15/15] usb: typec: tcpci_maxim: Enable auto discharge disconnect Badhri Jagan Sridharan
2020-10-19 13:50 ` Heikki Krogerus
2020-10-08 7:46 ` [PATCH v10 00/15] TCPM support for FRS and AutoDischarge Disconnect Greg Kroah-Hartman
2020-10-08 17:54 ` Badhri Jagan Sridharan
2020-10-13 14:11 ` Rob Herring
2020-10-19 13:55 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019134048.GD1667571@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amelie.delaunay@st.com \
--cc=badhri@google.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mripard@kernel.org \
--cc=pmalani@chromium.org \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).