From: Rob Herring <robh@kernel.org>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Thierry Reding <treding@nvidia.com>,
Prashant Malani <pmalani@chromium.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v11 02/10] dt-bindings: usb: Maxim type-c controller device tree binding document
Date: Mon, 26 Oct 2020 09:03:21 -0500 [thread overview]
Message-ID: <20201026140321.GA73964@bogus> (raw)
In-Reply-To: <20201020093627.256885-3-badhri@google.com>
On Tue, Oct 20, 2020 at 02:36:19AM -0700, Badhri Jagan Sridharan wrote:
> Add device tree binding document for Maxim 33359 Type-C chip driver
>
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> ---
> Changes since v1:
> - Changing patch version to v6 to fix version number confusion.
>
> Changes since v6:
> - Migrated to yaml format.
>
> Changes since v7:
> - Rebase on usb-next
>
> Changes since v8:
> - Fix errors from make dt_binding_check as suggested by
> Rob Herring.
>
> Changes since v9:
> - additionalProperties: false as suggested by Rob Herring.
>
> Changes since v10:
> - Added the chip number to the binding as suggested by Rob Herring.
> - Renamed the filename as well.
>
> ---
> .../devicetree/bindings/usb/maxim,33359.yaml | 75 +++++++++++++++++++
> 1 file changed, 75 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/maxim,33359.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/maxim,33359.yaml b/Documentation/devicetree/bindings/usb/maxim,33359.yaml
> new file mode 100644
> index 000000000000..b02e7b228cde
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/maxim,33359.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/usb/maxim,33359.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Maxim TCPCI Type-C PD controller DT bindings
> +
> +maintainers:
> + - Badhri Jagan Sridharan <badhri@google.com>
> +
> +description: Maxim TCPCI Type-C PD controller
> +
> +properties:
> + compatible:
> + enum:
> + - maxim,33359
Maxim parts are generally named 'maxim,max[0-9]+'
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + connector:
> + type: object
> + $ref: ../connector/usb-connector.yaml#
> + description:
> + Properties for usb c connector.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - connector
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/usb/pd.h>
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + maxtcpc@25 {
> + compatible = "maxim,33359";
> + reg = <0x25>;
> + interrupt-parent = <&gpa8>;
> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +
> + connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + data-role = "dual";
> + power-role = "dual";
> + try-power-role = "sink";
> + self-powered;
> + op-sink-microwatt = <2600000>;
> + new-source-frs-typec-current = <FRS_5V_1P5A>;
> + source-pdos = <PDO_FIXED(5000, 900,
> + PDO_FIXED_SUSPEND |
> + PDO_FIXED_USB_COMM |
> + PDO_FIXED_DATA_SWAP |
> + PDO_FIXED_DUAL_ROLE)>;
> + sink-pdos = <PDO_FIXED(5000, 3000,
> + PDO_FIXED_USB_COMM |
> + PDO_FIXED_DATA_SWAP |
> + PDO_FIXED_DUAL_ROLE)
> + PDO_FIXED(9000, 2000, 0)>;
> + };
> + };
> + };
> +...
> --
> 2.29.0.rc1.297.gfa9743e501-goog
>
next prev parent reply other threads:[~2020-10-26 14:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 9:36 [PATCH v11 00/10] *** TCPM support for FRS and AutoDischarge Disconnect *** Badhri Jagan Sridharan
2020-10-20 9:36 ` [PATCH v11 01/10] dt-bindings: connector: Add property to set initial current cap for FRS Badhri Jagan Sridharan
2020-10-26 14:00 ` Rob Herring
2020-10-20 9:36 ` [PATCH v11 02/10] dt-bindings: usb: Maxim type-c controller device tree binding document Badhri Jagan Sridharan
2020-10-26 14:03 ` Rob Herring [this message]
2020-10-20 9:36 ` [PATCH v11 03/10] usb: typec: tcpci_maxim: Fix the compatible string Badhri Jagan Sridharan
2020-10-20 9:36 ` [PATCH v11 04/10] usb: typec: tcpm: Refactor logic for new-source-frs-typec-current Badhri Jagan Sridharan
2020-10-20 9:36 ` [PATCH v11 05/10] usb: typec: tcpm: frs sourcing vbus callback Badhri Jagan Sridharan
2020-10-20 9:36 ` [PATCH v11 06/10] usb: typec: tcpci: " Badhri Jagan Sridharan
2020-10-20 9:36 ` [PATCH v11 07/10] usb: typec: tcpci_maxim: Fix vbus stuck on upon diconnecting sink Badhri Jagan Sridharan
2020-10-20 9:36 ` [PATCH v11 08/10] usb: typec: tcpm: Implement enabling Auto Discharge disconnect support Badhri Jagan Sridharan
2020-10-20 9:36 ` [PATCH v11 09/10] usb: typec: tcpci: Implement Auto discharge disconnect callbacks Badhri Jagan Sridharan
2020-10-20 9:36 ` [PATCH v11 10/10] usb: typec: tcpci_maxim: Enable auto discharge disconnect Badhri Jagan Sridharan
2020-10-28 12:10 ` [PATCH v11 00/10] *** TCPM support for FRS and AutoDischarge Disconnect *** Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026140321.GA73964@bogus \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=badhri@google.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mripard@kernel.org \
--cc=pmalani@chromium.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).