From: Jack Pham <jackp@codeaurora.org>
To: Wesley Cheng <wcheng@codeaurora.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org, balbi@kernel.org,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v7 4/5] usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default
Date: Fri, 29 Jan 2021 01:24:18 -0800 [thread overview]
Message-ID: <20210129092418.GA1879@jackp-linux.qualcomm.com> (raw)
In-Reply-To: <1611895604-4496-5-git-send-email-wcheng@codeaurora.org>
Hi Wesley,
On Thu, Jan 28, 2021 at 08:46:43PM -0800, Wesley Cheng wrote:
> In order to take advantage of the TX fifo resizing logic, manually add
> these properties to the DWC3 child node by default. This will allow
> the DWC3 gadget to resize the TX fifos for the IN endpoints, which
> help with performance.
>
> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index d803ee9..4ea6be3 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -564,6 +564,7 @@ static int dwc3_qcom_clk_init(struct dwc3_qcom *qcom, int count)
>
> static const struct property_entry dwc3_qcom_acpi_properties[] = {
> PROPERTY_ENTRY_STRING("dr_mode", "host"),
> + PROPERTY_ENTRY_BOOL("tx-fifo-resize"),
> {}
> };
>
> @@ -634,6 +635,7 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev)
> struct dwc3_qcom *qcom = platform_get_drvdata(pdev);
> struct device_node *np = pdev->dev.of_node, *dwc3_np;
> struct device *dev = &pdev->dev;
> + struct property *prop;
> int ret;
>
> dwc3_np = of_get_child_by_name(np, "dwc3");
> @@ -642,6 +644,14 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev)
> return -ENODEV;
> }
>
> + prop = kzalloc(sizeof(*prop), GFP_KERNEL);
> + if (prop) {
> + prop->name = "tx-fifo-resize";
> + ret = of_add_property(dwc3_np, prop);
> + if (ret < 0)
> + dev_info(dev, "unable to add tx-fifo-resize prop\n");
You'll need to kfree(prop) both in case of error here as well as in the
driver's .remove() callback. Maybe easier to devm_kzalloc()?
Jack
next prev parent reply other threads:[~2021-01-29 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 4:46 [PATCH v7 0/5] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng
2021-01-29 4:46 ` [PATCH v7 1/5] usb: gadget: udc: core: Introduce check_config to verify USB configuration Wesley Cheng
2021-01-29 4:46 ` [PATCH v7 2/5] usb: gadget: configfs: Check USB configuration before adding Wesley Cheng
2021-01-29 4:46 ` [PATCH v7 3/5] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng
2021-01-29 4:46 ` [PATCH v7 4/5] usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default Wesley Cheng
2021-01-29 9:24 ` Jack Pham [this message]
2021-01-29 20:30 ` Wesley Cheng
2021-02-02 16:23 ` Bjorn Andersson
2021-02-18 0:49 ` Wesley Cheng
2021-01-29 4:46 ` [PATCH v7 5/5] dt-bindings: usb: dwc3: Update dwc3 TX fifo properties Wesley Cheng
2021-02-05 20:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129092418.GA1879@jackp-linux.qualcomm.com \
--to=jackp@codeaurora.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).