From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Benson Leung <bleung@chromium.org>
Cc: enric.balletbo@collabora.com, pmalani@chromium.org,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, groeck@chromium.org,
bleung@google.com
Subject: Re: [PATCH 3/6] usb: typec: Add typec_partner_set_pd_revision
Date: Mon, 1 Feb 2021 14:41:47 +0200 [thread overview]
Message-ID: <20210201124147.GC2465@kuha.fi.intel.com> (raw)
In-Reply-To: <20210129061406.2680146-4-bleung@chromium.org>
On Thu, Jan 28, 2021 at 10:14:03PM -0800, Benson Leung wrote:
> The partner's PD revision may be resolved later than the port partner
> registration since the port partner creation may take place once
> Type-C detects the port has changed state, but before PD communication is
> completed.
>
> Add a setter so that the partner's PD revision can be attached to it once
> it becomes available.
>
> If the revision is set to a valid version (not 0), the setter will also
> refresh the partner's usb_pd flag and notify on "supports_usb_power_delivery"
> sysfs property as well.
>
> Signed-off-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/class.c | 30 ++++++++++++++++++++++++++++++
> include/linux/usb/typec.h | 1 +
> 2 files changed, 31 insertions(+)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index b5241f4756c2..b6ceab3dc16b 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -748,6 +748,36 @@ int typec_partner_set_identity(struct typec_partner *partner)
> }
> EXPORT_SYMBOL_GPL(typec_partner_set_identity);
>
> +/**
> + * typec_partner_set_pd_revision - Set the PD revision supported by the partner
> + * @partner: The partner to be updated.
> + * @pd_revision: USB Power Delivery Specification Revision supported by partner
> + *
> + * This routine is used to report that the PD revision of the port partner has
> + * become available.
> + *
> + * Returns 0 on success or negative error number on failure.
> + */
> +int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
> +{
> + int ret;
> +
> + if (partner->pd_revision == pd_revision)
> + return 0;
> +
> + partner->pd_revision = pd_revision;
> + sysfs_notify(&partner->dev.kobj, NULL, "usb_power_delivery_revision");
> + if (pd_revision != 0 && !partner->usb_pd) {
> + partner->usb_pd = 1;
> + sysfs_notify(&partner->dev.kobj, NULL,
> + "supports_usb_power_delivery");
> + }
> + kobject_uevent(&partner->dev.kobj, KOBJ_CHANGE);
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(typec_partner_set_pd_revision);
> +
> /**
> * typec_partner_set_num_altmodes - Set the number of available partner altmodes
> * @partner: The partner to be updated.
> diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h
> index 42c6b7c07a99..4946eca742d5 100644
> --- a/include/linux/usb/typec.h
> +++ b/include/linux/usb/typec.h
> @@ -126,6 +126,7 @@ struct typec_altmode_desc {
> enum typec_port_data roles;
> };
>
> +int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision);
> int typec_partner_set_num_altmodes(struct typec_partner *partner, int num_altmodes);
> struct typec_altmode
> *typec_partner_register_altmode(struct typec_partner *partner,
> --
> 2.30.0.365.g02bc693789-goog
thanks,
--
heikki
next prev parent reply other threads:[~2021-02-01 12:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 6:14 [PATCH 0/6] usb: typec: and platform/chrome: Add PD revision numbers Benson Leung
2021-01-29 6:14 ` [PATCH 1/6] usb: typec: Standardize PD Revision format with Type-C Revision Benson Leung
2021-02-01 12:38 ` Heikki Krogerus
2021-01-29 6:14 ` [PATCH 2/6] usb: typec: Provide PD Specification Revision for cable and partner Benson Leung
2021-02-01 12:40 ` Heikki Krogerus
2021-01-29 6:14 ` [PATCH 3/6] usb: typec: Add typec_partner_set_pd_revision Benson Leung
2021-02-01 12:41 ` Heikki Krogerus [this message]
2021-01-29 6:14 ` [PATCH 4/6] platform/chrome: cros_ec_typec: Report SOP' PD revision from status Benson Leung
2021-02-01 12:51 ` Heikki Krogerus
2021-02-01 14:33 ` Enric Balletbo i Serra
2021-02-01 18:12 ` Prashant Malani
2021-01-29 6:14 ` [PATCH 5/6] platform/chrome: cros_ec_typec: Set Partner " Benson Leung
2021-02-01 12:52 ` Heikki Krogerus
2021-02-01 14:33 ` Enric Balletbo i Serra
2021-02-01 18:13 ` Prashant Malani
2021-01-29 6:14 ` [PATCH 6/6] platform/chrome: cros_ec_typec: Set opmode to PD on SOP connected Benson Leung
2021-02-01 12:55 ` Heikki Krogerus
2021-02-01 14:33 ` Enric Balletbo i Serra
2021-02-01 18:15 ` Prashant Malani
2021-02-01 14:32 ` [PATCH 0/6] usb: typec: and platform/chrome: Add PD revision numbers Greg KH
2021-02-02 7:04 ` Benson Leung
2021-02-02 7:32 ` Greg KH
2021-02-01 14:37 ` Enric Balletbo i Serra
2021-02-01 14:43 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201124147.GC2465@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=bleung@chromium.org \
--cc=bleung@google.com \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).