archive mirror
 help / color / mirror / Atom feed
From: Sascha Hauer <>
To: Rob Herring <>
	Minas Harutyunyan <>,,
Subject: Re: [PATCH v2 0/2] usb: dwc2: Use clk bulk API for supporting multiple clocks
Date: Wed, 10 Feb 2021 09:42:33 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Feb 09, 2021 at 10:54:24AM -0600, Rob Herring wrote:
> On Mon, Jan 25, 2021 at 10:38:23AM +0100, Sascha Hauer wrote:
> > Currently the dwc2 driver only supports a single clock. I have a board
> > here which has a dwc2 controller with a somewhat special clock routing
> > to the phy. Both the dwc2 controller and the ULPI phy get their phy
> > clock from a SI5351 clock generator. This clock generator has multiple
> > clock outputs which each is modelled as a separate clk in Linux.
> > Unfortunately the clock to the phy and the clock to the dwc2 core are on
> > two different output pins of the SI5351, so we have two clocks which
> > must be enabled.  The phy is driven by the usb-nop-xceiver driver which
> > supports a single clock. My first approach was to add support for a
> > second clock to that driver, but technically the other clock is
> > connected to the dwc2 core, so instead I added support for a second
> > clock to the dwc2 driver.  This can easily be archieved with the clk
> > bulk API as done in this series.
> Where is the usb-nop-xceiver single clock coming from?

It's coming from the SI5351 clock generator

> Maybe you shouldn't be using usb-nop-xceiver? There is a ULPI binding 
> though that alone doesn't really help you.

The clock that feeds the phy is handled by the usb-nop-xceiver just
fine, it's the clock that is fed to the DWC2 controller that I need
support for. I hope my other mail makes this clearer a bit.


Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       |  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      reply	other threads:[~2021-02-10  8:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25  9:38 [PATCH v2 0/2] usb: dwc2: Use clk bulk API for supporting multiple clocks Sascha Hauer
2021-01-25  9:38 ` [PATCH 1/2] dt-bindings: usb: dwc2: Add support for additional clock Sascha Hauer
2021-02-09 16:46   ` Rob Herring
2021-02-10  8:39     ` Sascha Hauer
2021-01-25  9:38 ` [PATCH 2/2] usb: dwc2: use clk bulk API for supporting additional clocks Sascha Hauer
2021-02-09 16:54 ` [PATCH v2 0/2] usb: dwc2: Use clk bulk API for supporting multiple clocks Rob Herring
2021-02-10  8:42   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).