[PATCH] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable

linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable
@ 2021-02-10 10:28 Stefan Ursella
  2021-02-10 11:04 ` Johan Hovold
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Stefan Ursella @ 2021-02-10 10:28 UTC (permalink / raw)
  Cc: stefan.ursella, Greg Kroah-Hartman, Kai-Heng Feng, Alan Stern,
	Johan Hovold, Kars Mulder, Jonathan Cox, Tomasz Meresiński,
	linux-usb, linux-kernel

Without this quirk starting a video capture from the device often fails with

kernel: uvcvideo: Failed to set UVC probe control : -110 (exp. 34).
Signed-off-by: Stefan Ursella <stefan.ursella@wolfvision.net>
---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index f232914de5fd..f888deaf7bab 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -480,6 +480,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* novation SoundControl XL */
 	{ USB_DEVICE(0x1235, 0x0061), .driver_info = USB_QUIRK_RESET_RESUME },
 
+	/* ELMO L-12F document camera */
+	{ USB_DEVICE(0x09a1, 0x0028), .driver_info = USB_QUIRK_DELAY_CTRL_MSG },
+
 	{ }  /* terminating entry must be last */
 };
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable
  2021-02-10 10:28 [PATCH] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable Stefan Ursella
@ 2021-02-10 11:04 ` Johan Hovold
  2021-02-10 11:23 ` Greg Kroah-Hartman
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2021-02-10 11:04 UTC (permalink / raw)
  To: Stefan Ursella
  Cc: Greg Kroah-Hartman, Kai-Heng Feng, Alan Stern, Kars Mulder,
	Jonathan Cox, Tomasz Meresiński, linux-usb, linux-kernel

On Wed, Feb 10, 2021 at 11:28:20AM +0100, Stefan Ursella wrote:
> Without this quirk starting a video capture from the device often fails with
> 
> kernel: uvcvideo: Failed to set UVC probe control : -110 (exp. 34).
> Signed-off-by: Stefan Ursella <stefan.ursella@wolfvision.net>
> ---
>  drivers/usb/core/quirks.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index f232914de5fd..f888deaf7bab 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -480,6 +480,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	/* novation SoundControl XL */
>  	{ USB_DEVICE(0x1235, 0x0061), .driver_info = USB_QUIRK_RESET_RESUME },
>  
> +	/* ELMO L-12F document camera */
> +	{ USB_DEVICE(0x09a1, 0x0028), .driver_info = USB_QUIRK_DELAY_CTRL_MSG },
> +

Please keep the entries sorted by VID/PID (all but the recently added
last one are).

>  	{ }  /* terminating entry must be last */
>  };

Johan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable
  2021-02-10 10:28 [PATCH] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable Stefan Ursella
  2021-02-10 11:04 ` Johan Hovold
@ 2021-02-10 11:23 ` Greg Kroah-Hartman
  2021-02-10 11:51 ` [PATCH v2] " Stefan Ursella
  2021-02-10 14:07 ` Stefan Ursella
  3 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2021-02-10 11:23 UTC (permalink / raw)
  To: Stefan Ursella
  Cc: Kai-Heng Feng, Alan Stern, Johan Hovold, Kars Mulder,
	Jonathan Cox, Tomasz Meresiński, linux-usb, linux-kernel

On Wed, Feb 10, 2021 at 11:28:20AM +0100, Stefan Ursella wrote:
> Without this quirk starting a video capture from the device often fails with
> 
> kernel: uvcvideo: Failed to set UVC probe control : -110 (exp. 34).
> Signed-off-by: Stefan Ursella <stefan.ursella@wolfvision.net>

Please always put an empty line right before your signed-off-by: line.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable
  2021-02-10 10:28 [PATCH] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable Stefan Ursella
  2021-02-10 11:04 ` Johan Hovold
  2021-02-10 11:23 ` Greg Kroah-Hartman
@ 2021-02-10 11:51 ` Stefan Ursella
  2021-02-10 12:11   ` Greg Kroah-Hartman
  2021-02-10 14:07 ` Stefan Ursella
  3 siblings, 1 reply; 6+ messages in thread
From: Stefan Ursella @ 2021-02-10 11:51 UTC (permalink / raw)
  Cc: stefan.ursella, Greg Kroah-Hartman, Johan Hovold, Kai-Heng Feng,
	Alan Stern, Kars Mulder, Tomasz Meresiński, linux-usb,
	linux-kernel

Without this quirk starting a video capture from the device often fails with

kernel: uvcvideo: Failed to set UVC probe control : -110 (exp. 34).

Signed-off-by: Stefan Ursella <stefan.ursella@wolfvision.net>
---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 84b5da0a26a5..270ad082d3ba 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -381,6 +381,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* X-Rite/Gretag-Macbeth Eye-One Pro display colorimeter */
 	{ USB_DEVICE(0x0971, 0x2000), .driver_info = USB_QUIRK_NO_SET_INTF },
 
+	/* ELMO L-12F document camera */
+	{ USB_DEVICE(0x09a1, 0x0028), .driver_info = USB_QUIRK_DELAY_CTRL_MSG },
+
 	/* Broadcom BCM92035DGROM BT dongle */
 	{ USB_DEVICE(0x0a5c, 0x2021), .driver_info = USB_QUIRK_RESET_RESUME },
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable
  2021-02-10 11:51 ` [PATCH v2] " Stefan Ursella
@ 2021-02-10 12:11   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2021-02-10 12:11 UTC (permalink / raw)
  To: Stefan Ursella
  Cc: Johan Hovold, Kai-Heng Feng, Alan Stern, Kars Mulder,
	Tomasz Meresiński, linux-usb, linux-kernel

On Wed, Feb 10, 2021 at 12:51:43PM +0100, Stefan Ursella wrote:
> Without this quirk starting a video capture from the device often fails with
> 
> kernel: uvcvideo: Failed to set UVC probe control : -110 (exp. 34).
> 
> Signed-off-by: Stefan Ursella <stefan.ursella@wolfvision.net>
> ---
>  drivers/usb/core/quirks.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 84b5da0a26a5..270ad082d3ba 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -381,6 +381,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	/* X-Rite/Gretag-Macbeth Eye-One Pro display colorimeter */
>  	{ USB_DEVICE(0x0971, 0x2000), .driver_info = USB_QUIRK_NO_SET_INTF },
>  
> +	/* ELMO L-12F document camera */
> +	{ USB_DEVICE(0x09a1, 0x0028), .driver_info = USB_QUIRK_DELAY_CTRL_MSG },
> +
>  	/* Broadcom BCM92035DGROM BT dongle */
>  	{ USB_DEVICE(0x0a5c, 0x2021), .driver_info = USB_QUIRK_RESET_RESUME },
>  
> -- 
> 2.17.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable
  2021-02-10 10:28 [PATCH] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable Stefan Ursella
                   ` (2 preceding siblings ...)
  2021-02-10 11:51 ` [PATCH v2] " Stefan Ursella
@ 2021-02-10 14:07 ` Stefan Ursella
  3 siblings, 0 replies; 6+ messages in thread
From: Stefan Ursella @ 2021-02-10 14:07 UTC (permalink / raw)
  Cc: stefan.ursella, Greg Kroah-Hartman, Johan Hovold, Kai-Heng Feng,
	Alan Stern, Tomasz Meresiński, Kars Mulder, linux-usb,
	linux-kernel

Without this quirk starting a video capture from the device often fails with

kernel: uvcvideo: Failed to set UVC probe control : -110 (exp. 34).

Signed-off-by: Stefan Ursella <stefan.ursella@wolfvision.net>
---
Changes in v2:
  - Add empty line before signed-off-by
  - Sort entry by VID/PID

 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 84b5da0a26a5..270ad082d3ba 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -381,6 +381,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* X-Rite/Gretag-Macbeth Eye-One Pro display colorimeter */
 	{ USB_DEVICE(0x0971, 0x2000), .driver_info = USB_QUIRK_NO_SET_INTF },
 
+	/* ELMO L-12F document camera */
+	{ USB_DEVICE(0x09a1, 0x0028), .driver_info = USB_QUIRK_DELAY_CTRL_MSG },
+
 	/* Broadcom BCM92035DGROM BT dongle */
 	{ USB_DEVICE(0x0a5c, 0x2021), .driver_info = USB_QUIRK_RESET_RESUME },
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-10 14:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 10:28 [PATCH] usb: quirks: add quirk to start video capture on ELMO L-12F document camera reliable Stefan Ursella
2021-02-10 11:04 ` Johan Hovold
2021-02-10 11:23 ` Greg Kroah-Hartman
2021-02-10 11:51 ` [PATCH v2] " Stefan Ursella
2021-02-10 12:11   ` Greg Kroah-Hartman
2021-02-10 14:07 ` Stefan Ursella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).